Summary: | [WK2] Add C API to retrieve the originating page of a WKDownload | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, beidson, benjamin, buildbot, cmarcelo, commit-queue, dbates, ggaren, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Chris Dumez
2017-09-07 13:09:38 PDT
Created attachment 320177 [details]
Patch
Comment on attachment 320177 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320177&action=review > Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp:102 > + m_originatingPage = page ? page->createWeakPtr() : WeakPtr<WebPageProxy>(); will nullptr not work? > Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:265 > +void PageClientImpl::handleDownloadRequest(DownloadProxy*) > { > - ASSERT_ARG(download, download); > - ASSERT([download->wrapper() isKindOfClass:[_WKDownload class]]); > - [static_cast<_WKDownload *>(download->wrapper()) setOriginatingWebView:m_webView]; > } It would be nice if we could remove this PageClient call completely and make all platforms do this the same way. It seems like that's all GTK is doing here, and WPE is in progress. Created attachment 320189 [details]
Patch
Attachment 320189 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/WeakPtr.h:95: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4]
Total errors found: 1 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 320189 [details] Patch Clearing flags on attachment: 320189 Committed r221766: <http://trac.webkit.org/changeset/221766> All reviewed patches have been landed. Closing bug. |