Bug 176493 – Remove new-run-webkit-httpd as it appears to be old

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Joseph Pecoraro]

Remove new-run-webkit-httpd as it appears to be old.

> # FIXME: currently this code only works with the Chromium ports and LigHTTPd.
> # It should be made to work on all ports.

It hits an error when I run it.

I'll leave in other LigHTTPd code since it seemed like it might be used for Tools/Scripts testing code.

[Joseph Pecoraro]

Created attachment 320093 [details]
[PATCH] Proposed Fix

[Alexey Proskuryakov]

Comment on attachment 320093 [details]
[PATCH] Proposed Fix

It’s quite sad to keep underlying code in, but this is an improvement anyway

[Joseph Pecoraro]

(In reply to Alexey Proskuryakov from comment #2)
> Comment on attachment 320093 [details]
> [PATCH] Proposed Fix
> 
> It’s quite sad to keep underlying code in, but this is an improvement anyway

If I had any way to figure out if it was used or not I'd remove it. As it is I can barely understand the python code that uses it. I find it very hard to follow.

[WebKit Commit Bot]

Comment on attachment 320093 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 320093

Committed r221715: <http://trac.webkit.org/changeset/221715>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

What happens if you simply delete all functions with "lighttpd" in the name, and then all files that are solely devoted to this server implementation? From brief grepping, it looks like the only non-mechanical case is websocket_server.py, which for some reason uses http_server.Lighttpd - I expect that moving a few lines of code will eliminate it from inheritance chain.

[Radar WebKit Bug Importer]

<rdar://problem/34694544>