Bug 176478

Summary:

bisect-builds started failing with invalid json

Product:

WebKit

Reporter:

Lucas Forschler <lforschler>

Component:

Tools / Tests

Assignee:

Lucas Forschler <lforschler>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, lforschler, mcatanzaro, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Update the json parsing implementation	lforschler: commit-queue-

Lucas Forschler

Reported 2017-09-06 15:57:11 PDT

the json retrieval portion of the API gateway recently started returning invalid json. After doing some google searching, it turns out they limit it to 1000 'things' returned. This breaks our use case. https://forums.aws.amazon.com/thread.jspa?messageID=702451&#702451

Attachments
Update the json parsing implementation (1.80 KB, patch) 2017-09-07 10:46 PDT, Lucas Forschler	lforschler: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-09-06 15:57:38 PDT

<rdar://problem/34293921>

Lucas Forschler

Comment 2 2017-09-06 16:20:24 PDT

Apparently this has recently been documented here: http://docs.aws.amazon.com/apigateway/latest/developerguide/limits.html

Lucas Forschler

Comment 3 2017-09-06 17:32:39 PDT

I have a fix that I'm iterating on now... basically we need to avoid using the foreach loop in the AWS body mapping template. Instead, I can just pass along the raw JSON without mapping it to a new output format.

Lucas Forschler

Comment 4 2017-09-07 10:46:45 PDT

Created attachment 320135 [details] Update the json parsing implementation

Aakash Jain

Comment 5 2017-09-07 10:49:28 PDT

rs=me assuming it is tested properly. It would be good to mention the links to AWS rest API v2 either in ChangeLog or in comments here.

Lucas Forschler

Comment 6 2017-09-07 10:55:15 PDT

Note, I have bumped our REST API implementation from v1 to v2. This is to avoid breaking anything currently relying on v1. Note, there is nothing else currently using this tool at the moment, but this should be done moving forward as a good engineering practice. old: REST_API_URL = 'https://q1tzqfy48e.execute-api.us-west-2.amazonaws.com/v1/' new: REST_API_URL = 'https://q1tzqfy48e.execute-api.us-west-2.amazonaws.com/v2/'

Lucas Forschler

Comment 7 2017-09-07 10:56:43 PDT

Committed revision 221741.

Note You need to log in before you can comment on or make changes to this bug.