Bug 176477

Summary:

Require LoggingHelper overrides to provide identifier

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

WebCore Misc.

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, jer.noble, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch.	none

Description Eric Carlson 2017-09-06 15:01:59 PDT

Require LoggingHelper overrides to provide an identifier instead of logging 'this'. Also get rid of "notice" log level, "info" seems to be enough.

Comment 1 Eric Carlson 2017-09-06 15:09:16 PDT

Created attachment 320064 [details]
Proposed patch.

Comment 2 WebKit Commit Bot 2017-09-06 19:33:01 PDT

Comment on attachment 320064 [details]
Proposed patch.

Clearing flags on attachment: 320064

Committed r221712: <http://trac.webkit.org/changeset/221712>

Comment 3 WebKit Commit Bot 2017-09-06 19:33:02 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Radar WebKit Bug Importer 2017-09-08 11:25:12 PDT

<rdar://problem/34335104>