Bug 176477

Summary: Require LoggingHelper overrides to provide identifier
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebCore Misc.Assignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch. none

Eric Carlson
Reported 2017-09-06 15:01:59 PDT
Require LoggingHelper overrides to provide an identifier instead of logging 'this'. Also get rid of "notice" log level, "info" seems to be enough.
Attachments
Proposed patch. (58.45 KB, patch)
2017-09-06 15:09 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2017-09-06 15:09:16 PDT
Created attachment 320064 [details] Proposed patch.
WebKit Commit Bot
Comment 2 2017-09-06 19:33:01 PDT
Comment on attachment 320064 [details] Proposed patch. Clearing flags on attachment: 320064 Committed r221712: <http://trac.webkit.org/changeset/221712>
WebKit Commit Bot
Comment 3 2017-09-06 19:33:02 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2017-09-08 11:25:12 PDT
<rdar://problem/34335104>
Note You need to log in before you can comment on or make changes to this bug.