Bug 176462

Summary: Support caching of Response with a ReadableStream body
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, cdumez, commit-queue, esprehn+autocc, kondapallykalyan, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2017-09-06 08:54:23 PDT
Support caching of Response with a ReadableStream body
Attachments
Patch (35.05 KB, patch)
2017-09-06 09:17 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (34.82 KB, patch)
2017-09-06 14:04 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-09-06 09:17:48 PDT
Created attachment 320028 [details] Patch
Alex Christensen
Comment 2 2017-09-06 13:26:02 PDT
Comment on attachment 320028 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320028&action=review > Source/WebCore/bindings/js/ReadableStream.cpp:105 > +enum class Method { Locked, Disturbed }; > +template<Method method> I think this should be two separate functions, or one with a function as a parameter. Most of the function is what is different. Making two functions wouldn't duplicate much code.
youenn fablet
Comment 3 2017-09-06 14:04:42 PDT
Created attachment 320060 [details] Patch for landing
youenn fablet
Comment 4 2017-09-06 14:08:46 PDT
(In reply to Alex Christensen from comment #2) > Comment on attachment 320028 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=320028&action=review > > > Source/WebCore/bindings/js/ReadableStream.cpp:105 > > +enum class Method { Locked, Disturbed }; > > +template<Method method> > > I think this should be two separate functions, or one with a function as a > parameter. Most of the function is what is different. Making two functions > wouldn't duplicate much code. Done
WebKit Commit Bot
Comment 5 2017-09-06 14:25:23 PDT
Comment on attachment 320060 [details] Patch for landing Clearing flags on attachment: 320060 Committed r221704: <http://trac.webkit.org/changeset/221704>
WebKit Commit Bot
Comment 6 2017-09-06 14:25:25 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-09-27 12:34:46 PDT
<rdar://problem/34693521>
Note You need to log in before you can comment on or make changes to this bug.