Bug 176457

Summary: status-bubbles turn orange after checking relevance of patch
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, lforschler, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=176332
Attachments:
Description Flags
Proposed patch
none
Screenshot with orange EWS bubbles
none
Screenshot with this fix none

Aakash Jain
Reported 2017-09-06 08:32:43 PDT
After https://bugs.webkit.org/show_bug.cgi?id=176332, bots started sending more information to the EWS server. However, after checking relevance of a patch, bubbles become yellow and shows following message: "This result is not final, as the issue could be a pre-existing one. Trying to determine that now" Since checking relevance step passed, it should not result in orange bubble.
Attachments
Proposed patch (1.10 KB, patch)
2017-09-06 08:36 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Screenshot with orange EWS bubbles (156.06 KB, image/png)
2017-09-06 08:40 PDT, Aakash Jain 		no flags
Details
Screenshot with this fix (103.10 KB, image/png)
2017-09-06 11:02 PDT, Aakash Jain 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2017-09-06 08:36:29 PDT
Created attachment 320020 [details] Proposed patch
Aakash Jain
Comment 2 2017-09-06 08:40:49 PDT
Created attachment 320022 [details] Screenshot with orange EWS bubbles
Aakash Jain
Comment 3 2017-09-06 11:02:45 PDT
Created attachment 320040 [details] Screenshot with this fix
WebKit Commit Bot
Comment 4 2017-09-06 13:21:51 PDT
Comment on attachment 320020 [details] Proposed patch Clearing flags on attachment: 320020 Committed r221696: <http://trac.webkit.org/changeset/221696>
WebKit Commit Bot
Comment 5 2017-09-06 13:21:52 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-09-27 12:37:20 PDT
<rdar://problem/34693621>
Note You need to log in before you can comment on or make changes to this bug.