Bug 176442

Summary: [Win] Tools/TestWebKitAPI/Tests/WTF/PriorityQueue.cpp fails to compile with MSVC 2015
Product: WebKit Reporter: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fujii.hironori, keith_miller, lforschler, webkit-bug-importer, yoshiaki.jitsukawa, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch take 2 none

Yoshiaki Jitsukawa
Reported 2017-09-05 23:07:48 PDT
Currently Tools/TestWebKitAPI/Tests/WTF/PriorityQueue.cpp fails to compile with MSVC 2015.
Attachments
Patch (3.88 KB, patch)
2017-09-05 23:18 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
Patch take 2 (4.27 KB, patch)
2017-09-05 23:37 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yoshiaki Jitsukawa
Comment 1 2017-09-05 23:18:20 PDT
Created attachment 319986 [details] Patch Trying to fix build with MSVC 2015. I'm not sure how long this version will be supported but, seeing webkitdirs.pm, looks like it's still supported now.
Keith Miller
Comment 2 2017-09-05 23:22:40 PDT
Comment on attachment 319986 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319986&action=review Looks pretty good to me. Minor nit though. > Tools/TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:59 > +#if defined(_MSC_VER) && _MSC_VER < 1910 // FIXME: Remove this after we stop supporting MSVC 2015. Can you file a bugzilla for this and link to it in your FIXMEs?
Fujii Hironori
Comment 3 2017-09-05 23:31:50 PDT
*** Bug 175706 has been marked as a duplicate of this bug. ***
Yoshiaki Jitsukawa
Comment 4 2017-09-05 23:32:58 PDT
(In reply to Keith Miller from comment #2) > Comment on attachment 319986 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=319986&action=review > > Looks pretty good to me. Minor nit though. > > > Tools/TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:59 > > +#if defined(_MSC_VER) && _MSC_VER < 1910 // FIXME: Remove this after we stop supporting MSVC 2015. > > Can you file a bugzilla for this and link to it in your FIXMEs? Thank you for your suggestion. I've filed Bug 176443.
Keith Miller
Comment 5 2017-09-05 23:36:04 PDT
(In reply to Yoshiaki Jitsukawa from comment #4) > (In reply to Keith Miller from comment #2) > > Comment on attachment 319986 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=319986&action=review > > > > Looks pretty good to me. Minor nit though. > > > > > Tools/TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:59 > > > +#if defined(_MSC_VER) && _MSC_VER < 1910 // FIXME: Remove this after we stop supporting MSVC 2015. > > > > Can you file a bugzilla for this and link to it in your FIXMEs? > > Thank you for your suggestion. I've filed Bug 176443. Great, thanks! Can you update your patch to link to your bug too?
Yoshiaki Jitsukawa
Comment 6 2017-09-05 23:37:09 PDT
Created attachment 319987 [details] Patch take 2
Keith Miller
Comment 7 2017-09-05 23:41:02 PDT
Comment on attachment 319987 [details] Patch take 2 r=me.
WebKit Commit Bot
Comment 8 2017-09-06 00:23:41 PDT
Comment on attachment 319987 [details] Patch take 2 Clearing flags on attachment: 319987 Committed r221666: <http://trac.webkit.org/changeset/221666>
WebKit Commit Bot
Comment 9 2017-09-06 00:23:43 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2017-09-27 12:51:11 PDT
<rdar://problem/34694142>
Note You need to log in before you can comment on or make changes to this bug.