Bug 176424

Summary: [Win] Enable DatatransferItems in DRT.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: Tools / TestsAssignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Per Arne Vollan
Reported 2017-09-05 14:50:45 PDT
DataTransferItems are currently not enabled in DRT on Windows.
Attachments
Patch (6.47 KB, patch)
2017-09-05 14:53 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (8.72 KB, patch)
2017-09-06 15:11 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2017-09-05 14:53:24 PDT
Created attachment 319938 [details] Patch
Brent Fulgham
Comment 2 2017-09-05 15:40:03 PDT
Comment on attachment 319938 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319938&action=review r=me, as long as we don't have shipping software that depends on IWebPreferencesPrivate5 having only two API points. > Source/WebKitLegacy/win/WebPreferences.h:263 > + virtual HRESULT STDMETHODCALLTYPE setDataTransferItemsEnabled(BOOL); Can you confirm that IWebPreferencesPrivate5 is not currently shipping to users? If it is, we will need to make IWPP6. :-(
Per Arne Vollan
Comment 3 2017-09-06 15:11:38 PDT
Created attachment 320065 [details] Patch
Per Arne Vollan
Comment 4 2017-09-06 15:12:59 PDT
(In reply to Brent Fulgham from comment #2) > Comment on attachment 319938 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=319938&action=review > > r=me, as long as we don't have shipping software that depends on > IWebPreferencesPrivate5 having only two API points. > > > Source/WebKitLegacy/win/WebPreferences.h:263 > > + virtual HRESULT STDMETHODCALLTYPE setDataTransferItemsEnabled(BOOL); > > Can you confirm that IWebPreferencesPrivate5 is not currently shipping to > users? If it is, we will need to make IWPP6. :-( I don't believe so, but to be on the safe side, I uploaded another patch for review which adds a new interface. Thanks for reviewing!
Brent Fulgham
Comment 5 2017-09-06 16:45:02 PDT
Comment on attachment 320065 [details] Patch r=me
WebKit Commit Bot
Comment 6 2017-09-07 08:55:23 PDT
Comment on attachment 320065 [details] Patch Clearing flags on attachment: 320065 Committed r221733: <http://trac.webkit.org/changeset/221733>
WebKit Commit Bot
Comment 7 2017-09-07 08:55:24 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-09-27 12:38:13 PDT
<rdar://problem/34693655>
Note You need to log in before you can comment on or make changes to this bug.