Bug 176387

Summary: [Win] Compile errors in pathByAppendingComponents.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebCore Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Per Arne Vollan 2017-09-05 11:26:17 PDT 
C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\FileSystemWin.cpp(268): error C2440: 'initializing': cannot convert from 'WTF::StringView' to 'WTF::String' [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
  C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\FileSystemWin.cpp(268): note: No constructor could take the source type, or constructor overload resolution was ambiguous
C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\FileSystemWin.cpp(270): error C2664: 'WTF::String WebCore::pathByAppendingComponent(const WTF::String &,const WTF::String &)': cannot convert argument 2 from 'const WTF::StringView' to 'const WTF::String &' [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
  C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\FileSystemWin.cpp(270): note: Reason: cannot convert from 'const WTF::StringView' to 'const WTF::String'
  C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\FileSystemWin.cpp(270): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
Comment 1 Per Arne Vollan 2017-09-05 11:28:05 PDT 
Created attachment 319918 [details]
Patch
Comment 2 Brent Fulgham 2017-09-05 11:30:41 PDT 
Comment on attachment 319918 [details]
Patch

r=me.
Comment 3 Per Arne Vollan 2017-09-05 11:33:04 PDT 
Comment on attachment 319918 [details]
Patch

Thanks for reviewing!
Comment 4 WebKit Commit Bot 2017-09-05 12:02:34 PDT 
Comment on attachment 319918 [details]
Patch

Clearing flags on attachment: 319918

Committed r221628: <http://trac.webkit.org/changeset/221628>
Comment 5 WebKit Commit Bot 2017-09-05 12:02:35 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Chris Dumez 2017-09-05 12:06:27 PDT 
Thanks for fixing!
Comment 7 Per Arne Vollan 2017-09-05 12:28:59 PDT 
(In reply to Chris Dumez from comment #6)
> Thanks for fixing!

No problem :)
Comment 8 Radar WebKit Bug Importer 2017-09-27 12:35:51 PDT 
<rdar://problem/34693568>