Bug 176348

Summary: [iOS WK2] Add plumbing for WKContentView to ask the web process for additional drag items
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, megan_gardner, thorton
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 176421    
Attachments:
Description Flags
First pass
none
Tweak ChangeLog wording
none
Patch none

Wenson Hsieh
Reported 2017-09-04 22:16:24 PDT
Work towards <rdar://problem/31144674>
Attachments
First pass (41.27 KB, patch)
2017-09-04 23:40 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Tweak ChangeLog wording (41.41 KB, patch)
2017-09-05 08:44 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (41.38 KB, patch)
2017-09-05 12:50 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2017-09-04 23:40:40 PDT
Created attachment 319880 [details] First pass
Wenson Hsieh
Comment 2 2017-09-05 08:44:20 PDT
Created attachment 319900 [details] Tweak ChangeLog wording
Wenson Hsieh
Comment 3 2017-09-05 09:18:21 PDT
Comment on attachment 319900 [details] Tweak ChangeLog wording View in context: https://bugs.webkit.org/attachment.cgi?id=319900&action=review > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:634 > +void WebPage::requestAdditionalItemsForDragSession(const WebCore::IntPoint& clientPosition, const WebCore::IntPoint& globalPosition) WebCore:: namespace prefixes shouldn't be necessary here, nor in WebPageProxy. I'll remove these (either here, or in the next patch in the sequence).
Wenson Hsieh
Comment 4 2017-09-05 12:50:52 PDT
Created attachment 319928 [details] Patch
Wenson Hsieh
Comment 5 2017-09-05 17:49:17 PDT
(This is the second patch in the sequence -- final part here: https://bugs.webkit.org/show_bug.cgi?id=176421)
Wenson Hsieh
Comment 6 2017-09-05 19:13:00 PDT
Comment on attachment 319928 [details] Patch Thanks Tim!
WebKit Commit Bot
Comment 7 2017-09-05 19:41:55 PDT
Comment on attachment 319928 [details] Patch Clearing flags on attachment: 319928 Committed r221660: <http://trac.webkit.org/changeset/221660>
WebKit Commit Bot
Comment 8 2017-09-05 19:41:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.