Bug 176348

Summary: [iOS WK2] Add plumbing for WKContentView to ask the web process for additional drag items
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, megan_gardner, thorton
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 176421    
Attachments:
Description Flags
First pass
none
Tweak ChangeLog wording
none
Patch none

Description Wenson Hsieh 2017-09-04 22:16:24 PDT 
Work towards <rdar://problem/31144674>
Comment 1 Wenson Hsieh 2017-09-04 23:40:40 PDT 
Created attachment 319880 [details]
First pass
Comment 2 Wenson Hsieh 2017-09-05 08:44:20 PDT 
Created attachment 319900 [details]
Tweak ChangeLog wording
Comment 3 Wenson Hsieh 2017-09-05 09:18:21 PDT 
Comment on attachment 319900 [details]
Tweak ChangeLog wording

View in context: https://bugs.webkit.org/attachment.cgi?id=319900&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:634
> +void WebPage::requestAdditionalItemsForDragSession(const WebCore::IntPoint& clientPosition, const WebCore::IntPoint& globalPosition)

WebCore:: namespace prefixes shouldn't be necessary here, nor in WebPageProxy. I'll remove these (either here, or in the next patch in the sequence).
Comment 4 Wenson Hsieh 2017-09-05 12:50:52 PDT 
Created attachment 319928 [details]
Patch
Comment 5 Wenson Hsieh 2017-09-05 17:49:17 PDT 
(This is the second patch in the sequence -- final part here: https://bugs.webkit.org/show_bug.cgi?id=176421)
Comment 6 Wenson Hsieh 2017-09-05 19:13:00 PDT 
Comment on attachment 319928 [details]
Patch

Thanks Tim!
Comment 7 WebKit Commit Bot 2017-09-05 19:41:55 PDT 
Comment on attachment 319928 [details]
Patch

Clearing flags on attachment: 319928

Committed r221660: <http://trac.webkit.org/changeset/221660>
Comment 8 WebKit Commit Bot 2017-09-05 19:41:57 PDT 
All reviewed patches have been landed.  Closing bug.