Bug 176330

Summary: [GTK] Rename PLUGIN_ARCHITECTURE(X11) as PLUGIN_ARCHITECTURE(UNIX)
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 176329    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
mcatanzaro: review+
Patch for landing none

Carlos Garcia Campos
Reported 2017-09-04 06:29:08 PDT
It's no longer X11 specific since it's also used in Wayland when the X11 target is enabled. It should be renamed as UNIX and make it available when building the wayland target even if the X11 on is disabled.
Attachments
Patch (15.99 KB, patch)
2017-09-04 06:36 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (16.33 KB, patch)
2017-09-04 06:54 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
Patch for landing (16.34 KB, patch)
2017-09-05 00:23 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-09-04 06:36:54 PDT
Created attachment 319849 [details] Patch
Carlos Garcia Campos
Comment 2 2017-09-04 06:54:28 PDT
Created attachment 319850 [details] Patch
Michael Catanzaro
Comment 3 2017-09-04 11:55:45 PDT
Comment on attachment 319850 [details] Patch /home/ews/ltilve-gtk-wk2-ews/WebKit/Source/WebKit/Shared/Plugins/Netscape/unix/NetscapePluginModuleUnix.cpp: In member function 'void WebKit::NetscapePluginModule::determineQuirks()': /home/ews/ltilve-gtk-wk2-ews/WebKit/Source/WebKit/Shared/Plugins/Netscape/unix/NetscapePluginModuleUnix.cpp:187:32: error: 'IgnoreRightClickInWindowlessMode' is not a member of 'WebKit::PluginQuirks' /home/ews/ltilve-gtk-wk2-ews/WebKit/Source/WebKit/Shared/Plugins/Netscape/unix/NetscapePluginModuleUnix.cpp:189:32: error: 'DoNotCancelSrcStreamInWindowedMode' is not a member of 'WebKit::PluginQuirks'
Carlos Garcia Campos
Comment 4 2017-09-05 00:04:30 PDT
Build failure is because this patch depends on the other one, I'll submit a patch for EWS before landing anyway
Carlos Garcia Campos
Comment 5 2017-09-05 00:23:04 PDT
Created attachment 319881 [details] Patch for landing
Carlos Garcia Campos
Comment 6 2017-09-05 00:39:54 PDT
Committed r221610: <http://trac.webkit.org/changeset/221610>
Note You need to log in before you can comment on or make changes to this bug.