Bug 176330 - [GTK] Rename PLUGIN_ARCHITECTURE(X11) as PLUGIN_ARCHITECTURE(UNIX)
Summary: [GTK] Rename PLUGIN_ARCHITECTURE(X11) as PLUGIN_ARCHITECTURE(UNIX)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 176329
Blocks:
  Show dependency treegraph
 
Reported: 2017-09-04 06:29 PDT by Carlos Garcia Campos
Modified: 2017-09-05 00:39 PDT (History)
2 users (show)

See Also:


Attachments
Patch (15.99 KB, patch)
2017-09-04 06:36 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Patch (16.33 KB, patch)
2017-09-04 06:54 PDT, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff
Patch for landing (16.34 KB, patch)
2017-09-05 00:23 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-09-04 06:29:08 PDT
It's no longer X11 specific since it's also used in Wayland when the X11 target is enabled. It should be renamed as UNIX and make it available when building the wayland target even if the X11 on is disabled.
Comment 1 Carlos Garcia Campos 2017-09-04 06:36:54 PDT
Created attachment 319849 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-09-04 06:54:28 PDT
Created attachment 319850 [details]
Patch
Comment 3 Michael Catanzaro 2017-09-04 11:55:45 PDT
Comment on attachment 319850 [details]
Patch

/home/ews/ltilve-gtk-wk2-ews/WebKit/Source/WebKit/Shared/Plugins/Netscape/unix/NetscapePluginModuleUnix.cpp: In member function 'void WebKit::NetscapePluginModule::determineQuirks()':
/home/ews/ltilve-gtk-wk2-ews/WebKit/Source/WebKit/Shared/Plugins/Netscape/unix/NetscapePluginModuleUnix.cpp:187:32: error: 'IgnoreRightClickInWindowlessMode' is not a member of 'WebKit::PluginQuirks'
/home/ews/ltilve-gtk-wk2-ews/WebKit/Source/WebKit/Shared/Plugins/Netscape/unix/NetscapePluginModuleUnix.cpp:189:32: error: 'DoNotCancelSrcStreamInWindowedMode' is not a member of 'WebKit::PluginQuirks'
Comment 4 Carlos Garcia Campos 2017-09-05 00:04:30 PDT
Build failure is because this patch depends on the other one, I'll submit a patch for EWS before landing anyway
Comment 5 Carlos Garcia Campos 2017-09-05 00:23:04 PDT
Created attachment 319881 [details]
Patch for landing
Comment 6 Carlos Garcia Campos 2017-09-05 00:39:54 PDT
Committed r221610: <http://trac.webkit.org/changeset/221610>