| Summary: | Move shared part of the Remote Layer Tree code out of a Mac-specific directory | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | buildbot, commit-queue, mitz, simon.fraser, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2017-09-03 00:58:18 PDT
Created attachment 319766 [details]
Patch
Attachment 319766 [details] did not pass style-queue:
ERROR: Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5]
ERROR: Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h:66: The parameter name "volatilityMarkingFlags" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5]
ERROR: Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:489: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.h:93: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5]
Total errors found: 6 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 319766 [details]
Patch
rs=me
Comment on attachment 319766 [details] Patch Clearing flags on attachment: 319766 Committed r221554: <http://trac.webkit.org/changeset/221554> All reviewed patches have been landed. Closing bug. |