Bug 176297

Summary: Move shared part of the Remote Layer Tree code out of a Mac-specific directory
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, mitz, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tim Horton
Reported 2017-09-03 00:58:18 PDT
Move shared part of the Remote Layer Tree code out of a Mac-specific directory
Attachments
Patch (267.49 KB, patch)
2017-09-03 00:58 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2017-09-03 00:58:50 PDT
Created attachment 319766 [details] Patch
Build Bot
Comment 2 2017-09-03 01:02:01 PDT
Attachment 319766 [details] did not pass style-queue: ERROR: Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h:66: The parameter name "volatilityMarkingFlags" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:489: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.h:93: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 6 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3 2017-09-03 09:04:15 PDT
Comment on attachment 319766 [details] Patch rs=me
WebKit Commit Bot
Comment 4 2017-09-03 12:08:10 PDT
Comment on attachment 319766 [details] Patch Clearing flags on attachment: 319766 Committed r221554: <http://trac.webkit.org/changeset/221554>
WebKit Commit Bot
Comment 5 2017-09-03 12:08:12 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-09-27 12:54:37 PDT
<rdar://problem/34694253>
Note You need to log in before you can comment on or make changes to this bug.