Bug 176297 - Move shared part of the Remote Layer Tree code out of a Mac-specific directory
Summary: Move shared part of the Remote Layer Tree code out of a Mac-specific directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-03 00:58 PDT by Tim Horton
Modified: 2017-09-27 12:54 PDT (History)
5 users (show)

See Also:

Attachments
Patch (267.49 KB, patch)
2017-09-03 00:58 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-09-03 00:58:18 PDT 
Move shared part of the Remote Layer Tree code out of a Mac-specific directory
Comment 1 Tim Horton 2017-09-03 00:58:50 PDT 
Created attachment 319766 [details]
Patch
Comment 2 Build Bot 2017-09-03 01:02:01 PDT 
Attachment 319766 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h:66:  The parameter name "volatilityMarkingFlags" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:489:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.h:93:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
Total errors found: 6 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2017-09-03 09:04:15 PDT 
Comment on attachment 319766 [details]
Patch

rs=me
Comment 4 WebKit Commit Bot 2017-09-03 12:08:10 PDT 
Comment on attachment 319766 [details]
Patch

Clearing flags on attachment: 319766

Committed r221554: <http://trac.webkit.org/changeset/221554>
Comment 5 WebKit Commit Bot 2017-09-03 12:08:12 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:54:37 PDT 
<rdar://problem/34694253>