Bug 176291

Summary: Need an API to get the global context from JSObjectRef
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Oliver Hunt
Reported 2017-09-02 20:51:20 PDT
Need an API to get the global context from JSObjectRef
Attachments
Patch (3.62 KB, patch)
2017-09-02 20:52 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2017-09-02 20:52:11 PDT
Created attachment 319758 [details] Patch
Build Bot
Comment 2 2017-09-02 20:54:54 PDT
Attachment 319758 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/API/tests/testapi.c:2054: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:72: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2017-09-02 21:42:55 PDT
Comment on attachment 319758 [details] Patch Clearing flags on attachment: 319758 Committed r221546: <http://trac.webkit.org/changeset/221546>
WebKit Commit Bot
Comment 4 2017-09-02 21:42:56 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-09-27 12:41:37 PDT
<rdar://problem/34693773>
Note You need to log in before you can comment on or make changes to this bug.