Bug 176291 - Need an API to get the global context from JSObjectRef
Summary: Need an API to get the global context from JSObjectRef
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-02 20:51 PDT by Oliver Hunt
Modified: 2017-09-27 12:41 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.62 KB, patch)
2017-09-02 20:52 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2017-09-02 20:51:20 PDT 
Need an API to get the global context from JSObjectRef
Comment 1 Oliver Hunt 2017-09-02 20:52:11 PDT 
Created attachment 319758 [details]
Patch
Comment 2 Build Bot 2017-09-02 20:54:54 PDT 
Attachment 319758 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/API/tests/testapi.c:2054:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:72:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2017-09-02 21:42:55 PDT 
Comment on attachment 319758 [details]
Patch

Clearing flags on attachment: 319758

Committed r221546: <http://trac.webkit.org/changeset/221546>
Comment 4 WebKit Commit Bot 2017-09-02 21:42:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-09-27 12:41:37 PDT 
<rdar://problem/34693773>