Bug 176274

Summary: Add WKUIDelegatePrivate equivalent of WKPageUIClient's unavailablePluginButtonClicked
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Alex Christensen 2017-09-02 01:25:09 PDT
Add WKUIDelegatePrivate equivalent of WKPageUIClient's unavailablePluginButtonClicked
Comment 1 Alex Christensen 2017-09-02 01:25:57 PDT
Created attachment 319709 [details]
Patch
Comment 2 Darin Adler 2017-09-02 10:56:37 PDT
Comment on attachment 319709 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319709&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:120
> +#if !TARGET_OS_IOS

I think this should be written in the affirmative, #if TARGET_OS_MAC (whatever the right name for that is), because the default for any new target should be no plugins.

Also, in the past I thought the official name was "plug-in", not "plugin", and therefore the "I" would be capitalized in public identifiers like _plugInsEnabled.
Comment 3 Alex Christensen 2017-09-04 21:32:08 PDT
Created attachment 319873 [details]
Patch
Comment 4 Alex Christensen 2017-09-04 22:14:48 PDT
Created attachment 319877 [details]
Patch
Comment 5 Alex Christensen 2017-09-04 22:26:00 PDT
TARGET_OS_OSX didn't seem to work and it isn't used anywhere else.  I changed it to !if !TARGET_OS_IPHONE which seems to mean just Mac, not phones, tablets, watches, tvs, or anything else so far.
Comment 6 Alex Christensen 2017-09-05 10:37:05 PDT
http://trac.webkit.org/r221621
Comment 7 Radar WebKit Bug Importer 2017-09-27 12:53:31 PDT
<rdar://problem/34694218>