Summary: | Add WKUIDelegatePrivate equivalent of WKPageUIClient's unavailablePluginButtonClicked | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | darin, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Alex Christensen
2017-09-02 01:25:09 PDT
Created attachment 319709 [details]
Patch
Comment on attachment 319709 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319709&action=review > Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:120 > +#if !TARGET_OS_IOS I think this should be written in the affirmative, #if TARGET_OS_MAC (whatever the right name for that is), because the default for any new target should be no plugins. Also, in the past I thought the official name was "plug-in", not "plugin", and therefore the "I" would be capitalized in public identifiers like _plugInsEnabled. Created attachment 319873 [details]
Patch
Created attachment 319877 [details]
Patch
TARGET_OS_OSX didn't seem to work and it isn't used anywhere else. I changed it to !if !TARGET_OS_IPHONE which seems to mean just Mac, not phones, tablets, watches, tvs, or anything else so far. |