Bug 176272

Summary:

Fix some style issues in the Web Process part of the Remote Layer Tree code

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, mitz, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	thorton: commit-queue+
Patch	none

Tim Horton

Reported 2017-09-02 00:47:07 PDT

Fix some style issues in the Web Process part of the Remote Layer Tree code

Attachments
Patch (13.11 KB, patch) 2017-09-02 00:47 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (13.23 KB, patch) 2017-09-02 01:24 PDT, Tim Horton	thorton: commit-queue+	Details Formatted Diff Diff
Patch (13.23 KB, patch) 2017-09-02 03:06 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2017-09-02 00:47:55 PDT

Created attachment 319700 [details] Patch

Tim Horton

Comment 2 2017-09-02 00:48:29 PDT

Not sure how I feel about the silly protector-name style nit, but if the bot enforces it I suppose we should follow it. The rest I wholly agree with.

mitz

Comment 3 2017-09-02 01:03:39 PDT

Comment on attachment 319700 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319700&action=review > Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:114 > + dispatch_async(dispatch_get_main_queue(), ^ { Very strange. I don’t seem to find a WebKit coding style guideline for blocks, and I believe the prevailing convention in WebKit is to omit the space. It looks like the script is applying a rule meant for something else to this block. Can you sidestep the issue by changing this into a lambda?

Tim Horton

Comment 4 2017-09-02 01:04:39 PDT

(In reply to mitz from comment #3) > Comment on attachment 319700 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=319700&action=review > > > Source/WebKit/WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:114 > > + dispatch_async(dispatch_get_main_queue(), ^ { > > Very strange. I don’t seem to find a WebKit coding style guideline for > blocks, and I believe the prevailing convention in WebKit is to omit the > space. It looks like the script is applying a rule meant for something else > to this block. Can you sidestep the issue by changing this into a lambda? Ah, I've been tripped up by this before, and I think this warning has caused us to be super inconsistent. /Especially/ because the text of it uses the word "block".

mitz

Comment 5 2017-09-02 01:23:04 PDT

Comment on attachment 319700 [details] Patch r=me with that space gone

Tim Horton

Comment 6 2017-09-02 01:24:48 PDT

Created attachment 319708 [details] Patch

Tim Horton

Comment 7 2017-09-02 03:06:12 PDT

Created attachment 319712 [details] Patch

WebKit Commit Bot

Comment 8 2017-09-02 03:48:37 PDT

Comment on attachment 319712 [details] Patch Clearing flags on attachment: 319712 Committed r221537: <http://trac.webkit.org/changeset/221537>