Bug 176239

Summary: Make PageClientImplCocoa a proper superclass of PageClientImpls for Mac and iOS
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2017-09-01 12:32:30 PDT
Make PageClientImplCocoa a proper superclass of PageClientImpls for Mac and iOS
Attachments
Patch (98.41 KB, patch)
2017-09-01 12:34 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (99.28 KB, patch)
2017-09-01 12:39 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (99.31 KB, patch)
2017-09-01 13:16 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-09-01 12:34:03 PDT
Created attachment 319629 [details] Patch
Build Bot
Comment 2 2017-09-01 12:35:46 PDT
Attachment 319629 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/mac/PageClientImplMac.h:120: The parameter name "layer" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/UIProcess/mac/PageClientImplMac.mm:180: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/UIProcess/mac/PageClientImplMac.mm:403: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 3 2017-09-01 12:39:31 PDT
Created attachment 319630 [details] Patch
Alex Christensen
Comment 4 2017-09-01 13:16:23 PDT
Created attachment 319639 [details] Patch
Alex Christensen
Comment 5 2017-09-01 15:19:40 PDT
http://trac.webkit.org/r221502
Radar WebKit Bug Importer
Comment 6 2017-09-27 12:51:14 PDT
<rdar://problem/34694145>
Note You need to log in before you can comment on or make changes to this bug.