| Summary: | Make LegacyCustomProtocolManager optional for network process | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Stephan Szabo <stephan.szabo> | ||||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, ap, commit-queue, darin, don.olmstead, rniwa, webkit-bug-importer, yoshiaki.jitsukawa, Yousuke.Kimoto | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Stephan Szabo
2017-09-01 10:28:07 PDT
Created attachment 327991 [details]
Make LegacyCustomProtocolManager optional for network process
Make LegacyCustomProtocolManager optional for a port as we were asked to not provide it for WinCairo. Move it from the common file into the individual ports that are currently using it and put code behind a feature disabled for WinCairo.
Uploading to test on the bots.
Thanks to Shukuwa-san for working on this
Comment on attachment 327991 [details]
Make LegacyCustomProtocolManager optional for network process
Bots appear to be happy at least.
Comment on attachment 327991 [details]
Make LegacyCustomProtocolManager optional for network process
Woah, this is good, but it needs to be enabled on Cocoa platforms which don't use CMake.
Created attachment 328045 [details]
Make LegacyCustomProtocolManager optional for network process - add FeatureDefines.xcconfig changes
Comment on attachment 328045 [details] Make LegacyCustomProtocolManager optional for network process - add FeatureDefines.xcconfig changes Clearing flags on attachment: 328045 Committed r225377: <https://trac.webkit.org/changeset/225377> All reviewed patches have been landed. Closing bug. |