Summary: | Speedometer: Reduce duplication in react-redux test | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mathias Bynens <mathias> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | addyo, buildbot, cdumez, commit-queue, gsathya, mathias, rniwa, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 172339 | ||||||
Attachments: |
|
Description
Mathias Bynens
2017-09-01 09:28:43 PDT
Created attachment 320122 [details]
Patch
It appears with the latest patch that the problem is no longer an issue (react-scripts may have discovered upstream that there were dupes caused by their build pipeline). The changes in the latest work here LGTM. Deferring to Ryosuke. Safari 10.1.2 (12603.3.8) Patched: 35.0 ± 0.71 33.4 ± 1.0 35.2 ± 1.4 34.8 ± 0.8 36.4 ± 1.1 35.9 ± 0.77 Unpatched: 33.3 ± 2.6 35.4 ± 0.99 35.5 ± 0.84 36.0 ± 0.99 35.5 ± 2.4 35.3 ± 0.66 Chrome 61.0.3163.79 Patched: 44.6 ± 1.5 43.8 ± 1.6 41.0 ± 3.2 43.5 ± 1.9 43.7 ± 1.8 44.7 ± 1.3 Unpatched: 43.8 ± 3.7 44.1 ± 1.5 46.3 ± 1.8 45.6 ± 1.6 46.3 ± 2.4 45.5 ± 1.4 Comment on attachment 320122 [details]
Patch
r=me
Comment on attachment 320122 [details] Patch Clearing flags on attachment: 320122 Committed r221841: <http://trac.webkit.org/changeset/221841> All reviewed patches have been landed. Closing bug. |