Bug 176212

Summary:

Replace WKUIDelegatePrivate's isPlayingMediaDidChange with KVO _isPlayingAudio on WKWebView

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto, buildbot, cgarcia, gustavo, mcatanzaro, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	thorton: review+

Alex Christensen

Reported 2017-08-31 22:53:38 PDT

Replace WKUIDelegatePrivate's isPlayingMediaDidChange with KVO _isPlayingAudio on WKWebView

Attachments
Patch (19.45 KB, patch) 2017-08-31 22:56 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (24.60 KB, patch) 2017-09-01 09:12 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (24.74 KB, patch) 2017-09-01 09:49 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (25.33 KB, patch) 2017-09-01 10:45 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (25.54 KB, patch) 2017-09-01 11:03 PDT, Alex Christensen	thorton: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2017-08-31 22:56:41 PDT

Created attachment 319578 [details] Patch

Build Bot

Comment 2 2017-08-31 22:58:37 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Alex Christensen

Comment 3 2017-09-01 09:12:21 PDT

Created attachment 319599 [details] Patch

Alex Christensen

Comment 4 2017-09-01 09:49:29 PDT

Created attachment 319604 [details] Patch

Alex Christensen

Comment 5 2017-09-01 10:45:45 PDT

Created attachment 319613 [details] Patch

Alex Christensen

Comment 6 2017-09-01 11:03:47 PDT

Created attachment 319621 [details] Patch