Summary: | Ensure RenderStyle and SameSizeAsRenderStyle have the same size | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||
Component: | WebCore Misc. | Assignee: | Daniel Bates <dbates> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, don.olmstead, pvollan, webkit-bug-importer, yoshiaki.jitsukawa | ||||||
Priority: | P2 | Keywords: | InRadar, PlatformOnly | ||||||
Version: | WebKit Local Build | ||||||||
Hardware: | PC | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 176171 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Daniel Bates
2017-08-31 20:16:14 PDT
Created attachment 319566 [details]
For EWS
I expect this patch to fail on the Windows EWS. This is for my sanity.
The size of RenderStyle and SameSizeAsRenderStyle are 0x34 and 0x38 bytes respectively on AppleWin (32 bit). static_assert(sizeof(RenderStyle) == 0x34, "0x34"); static_assert(sizeof(SameSizeAsRenderStyle) == 0x38, "0x38"); There's a 4 byte padding between SameSizeAsRenderStyle::m_inheritedFlags and SameSizeAsRenderStyle::m_nonInheritedFlags due to 64 bit align requirement for m_nonInheritedFlags (uint64_t). static_assert(offsetof(SameSizeAsRenderStyle, m_inheritedFlags) == 0x24, "0x24"); static_assert(offsetof(SameSizeAsRenderStyle, m_nonInheritedFlags) == 0x30, "0x30"); Created attachment 319582 [details]
Patch
Comment on attachment 319582 [details] Patch Clearing flags on attachment: 319582 Committed r221480: <http://trac.webkit.org/changeset/221480> All reviewed patches have been landed. Closing bug. |