Bug 176200

Summary:

[CG] Upstream CoreGraphics-related WebKitSystemInterface functions

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, buildbot, commit-queue, dino, eric.carlson, jer.noble, joepeck, rniwa, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Andy Estes

Reported 2017-08-31 17:18:41 PDT

[Cocoa] Upstream CoreGraphics-related WebKitSystemInterface functions

Attachments
Patch (59.24 KB, patch) 2017-08-31 17:19 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (59.06 KB, patch) 2017-08-31 17:28 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (59.90 KB, patch) 2017-08-31 17:40 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (60.36 KB, patch) 2017-08-31 20:39 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (60.41 KB, patch) 2017-08-31 20:53 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (60.44 KB, patch) 2017-08-31 21:02 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (62.04 KB, patch) 2017-08-31 22:27 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (62.05 KB, patch) 2017-08-31 22:38 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (62.23 KB, patch) 2017-08-31 23:35 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (62.60 KB, patch) 2017-08-31 23:52 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (63.25 KB, patch) 2017-09-01 00:58 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (63.71 KB, patch) 2017-09-01 08:36 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (63.72 KB, patch) 2017-09-01 08:52 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (63.76 KB, patch) 2017-09-01 09:34 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (63.78 KB, patch) 2017-09-01 09:44 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (64.04 KB, patch) 2017-09-01 09:56 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (70.90 KB, patch) 2017-09-01 10:56 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Show Obsolete (16) View All Add attachment proposed patch, testcase, etc.

Andy Estes

Comment 1 2017-08-31 17:19:42 PDT Comment hidden (obsolete)

Created attachment 319546 [details] Patch

Build Bot

Comment 2 2017-08-31 17:21:56 PDT Comment hidden (obsolete)

Attachment 319546 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:153: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:158: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 3 2017-08-31 17:28:05 PDT Comment hidden (obsolete)

Created attachment 319550 [details] Patch

Build Bot

Comment 4 2017-08-31 17:29:59 PDT Comment hidden (obsolete)

Attachment 319550 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:153: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 5 2017-08-31 17:40:37 PDT Comment hidden (obsolete)

Created attachment 319555 [details] Patch

Build Bot

Comment 6 2017-08-31 17:42:44 PDT Comment hidden (obsolete)

Attachment 319555 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:153: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:163: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:168: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:174: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:181: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 7 2017-08-31 20:39:34 PDT Comment hidden (obsolete)

Created attachment 319567 [details] Patch

Build Bot

Comment 8 2017-08-31 20:42:15 PDT Comment hidden (obsolete)

Attachment 319567 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:153: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:163: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:168: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:174: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:181: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 9 2017-08-31 20:53:57 PDT Comment hidden (obsolete)

Created attachment 319569 [details] Patch

Build Bot

Comment 10 2017-08-31 20:56:22 PDT Comment hidden (obsolete)

Attachment 319569 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:153: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:163: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:168: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:174: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:181: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 11 2017-08-31 21:02:21 PDT Comment hidden (obsolete)

Created attachment 319570 [details] Patch

Build Bot

Comment 12 2017-08-31 21:03:31 PDT Comment hidden (obsolete)

Attachment 319570 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:153: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:163: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:168: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:174: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:181: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 13 2017-08-31 22:27:10 PDT Comment hidden (obsolete)

Created attachment 319576 [details] Patch

Build Bot

Comment 14 2017-08-31 22:28:10 PDT Comment hidden (obsolete)

Attachment 319576 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:148: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:154: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:166: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:177: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 15 2017-08-31 22:38:25 PDT Comment hidden (obsolete)

Created attachment 319577 [details] Patch

Build Bot

Comment 16 2017-08-31 22:39:35 PDT Comment hidden (obsolete)

Attachment 319577 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:148: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:154: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:166: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:177: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 17 2017-08-31 23:35:15 PDT Comment hidden (obsolete)

Created attachment 319580 [details] Patch

Build Bot

Comment 18 2017-08-31 23:37:41 PDT Comment hidden (obsolete)

Attachment 319580 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:148: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:154: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:166: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:177: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 19 2017-08-31 23:52:33 PDT Comment hidden (obsolete)

Created attachment 319581 [details] Patch

Build Bot

Comment 20 2017-08-31 23:55:05 PDT Comment hidden (obsolete)

Attachment 319581 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:148: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:154: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:166: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:177: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 21 2017-09-01 00:58:04 PDT Comment hidden (obsolete)

Created attachment 319584 [details] Patch

Build Bot

Comment 22 2017-09-01 01:00:10 PDT Comment hidden (obsolete)

Attachment 319584 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:148: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:154: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:166: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:177: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 23 2017-09-01 08:36:26 PDT Comment hidden (obsolete)

Created attachment 319595 [details] Patch

Build Bot

Comment 24 2017-09-01 08:38:38 PDT Comment hidden (obsolete)

Attachment 319595 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:148: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:154: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:166: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:177: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 25 2017-09-01 08:52:32 PDT Comment hidden (obsolete)

Created attachment 319598 [details] Patch

Build Bot

Comment 26 2017-09-01 08:55:28 PDT Comment hidden (obsolete)

Attachment 319598 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:148: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:154: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:166: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:177: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 27 2017-09-01 09:34:58 PDT Comment hidden (obsolete)

Created attachment 319602 [details] Patch

Build Bot

Comment 28 2017-09-01 09:37:12 PDT Comment hidden (obsolete)

Attachment 319602 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:148: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:154: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:166: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:177: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 29 2017-09-01 09:44:29 PDT Comment hidden (obsolete)

Created attachment 319603 [details] Patch

Build Bot

Comment 30 2017-09-01 09:46:21 PDT Comment hidden (obsolete)

Attachment 319603 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:148: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:154: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:166: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:177: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 31 2017-09-01 09:56:23 PDT Comment hidden (obsolete)

Created attachment 319606 [details] Patch

Build Bot

Comment 32 2017-09-01 09:57:56 PDT Comment hidden (obsolete)

Attachment 319606 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:148: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:154: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:166: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:177: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 33 2017-09-01 10:56:00 PDT

Created attachment 319618 [details] Patch

WebKit Commit Bot

Comment 34 2017-09-01 11:37:33 PDT

Comment on attachment 319618 [details] Patch Clearing flags on attachment: 319618 Committed r221485: <http://trac.webkit.org/changeset/221485>

WebKit Commit Bot

Comment 35 2017-09-01 11:37:35 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 36 2017-09-27 12:46:06 PDT

<rdar://problem/34693910>

Note You need to log in before you can comment on or make changes to this bug.