Bug 176193

Summary: Element focus appearance update should be either immediate or a post-layout task
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andreas Kling
Reported 2017-08-31 16:01:47 PDT
We currently have a zero-timer hack for delaying an element's "focus appearance update" (mostly about scrolling into view if needed.) This is code from the long-long-ago that tried to avoid calling into layout during attach(). In modern day WebKit, we should be able to do this immediately when layout is clean, and as a post-layout callback otherwise.
Attachments
Patch (10.14 KB, patch)
2017-08-31 16:19 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (10.63 KB, patch)
2017-08-31 17:30 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2017-08-31 16:19:59 PDT
Created attachment 319538 [details] Patch
Andreas Kling
Comment 2 2017-08-31 17:30:34 PDT
Created attachment 319552 [details] Patch
Antti Koivisto
Comment 3 2017-08-31 17:35:05 PDT
r=me
WebKit Commit Bot
Comment 4 2017-08-31 18:17:20 PDT
Comment on attachment 319552 [details] Patch Clearing flags on attachment: 319552 Committed r221464: <http://trac.webkit.org/changeset/221464>
WebKit Commit Bot
Comment 5 2017-08-31 18:17:21 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-09-27 12:52:51 PDT
<rdar://problem/34694199>
Note You need to log in before you can comment on or make changes to this bug.