Bug 176181

Summary: Remove newBlockInsideInlineModel and anonymous inline block
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, commit-queue, don.olmstead, hyatt, kling, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
zalan: review+
patch none

Antti Koivisto
Reported 2017-08-31 13:23:28 PDT
Anonymous inline block exists to support newBlockInsideInlineModel which was planned to replace continuations. It has never been enabled and it is time to remove it.
Attachments
patch (53.71 KB, patch)
2017-08-31 13:28 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (79.37 KB, patch)
2017-08-31 14:16 PDT, Antti Koivisto 		zalan: review+
DetailsFormatted DiffDiff
patch (79.60 KB, patch)
2017-08-31 14:43 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2017-08-31 13:28:14 PDT
Created attachment 319511 [details] patch
Antti Koivisto
Comment 2 2017-08-31 14:16:48 PDT
Created attachment 319521 [details] patch
Build Bot
Comment 3 2017-08-31 14:18:54 PDT
Attachment 319521 [details] did not pass style-queue: ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/ios-wk1/TestExpectations:1421: Path does not exist. [test/expectations] [5] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 4 2017-08-31 14:43:19 PDT
Created attachment 319525 [details] patch
WebKit Commit Bot
Comment 5 2017-08-31 16:27:07 PDT
Comment on attachment 319525 [details] patch Clearing flags on attachment: 319525 Committed r221456: <http://trac.webkit.org/changeset/221456>
WebKit Commit Bot
Comment 6 2017-08-31 16:27:09 PDT
All reviewed patches have been landed. Closing bug.
Don Olmstead
Comment 7 2017-08-31 18:49:16 PDT
This broke AppleWin and WinCairo is having the same issues.
Radar WebKit Bug Importer
Comment 8 2017-09-27 12:59:53 PDT
<rdar://problem/34694451>
Note You need to log in before you can comment on or make changes to this bug.