Bug 176057

Summary:

Avoid full style recalcs when computing editability

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

HTML Editing

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

buildbot, rniwa, wenson_hsieh

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews116 for mac-elcapitan	none
Archive of layout-test-results from ews101 for mac-elcapitan	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none

Antti Koivisto

Reported 2017-08-29 10:16:09 PDT

It shouldn't be needed.

Attachments
patch (7.05 KB, patch) 2017-08-29 10:17 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (7.78 KB, patch) 2017-08-29 10:53 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.71 MB, application/zip) 2017-08-29 11:57 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-elcapitan (2.28 MB, application/zip) 2017-08-29 12:09 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews101 for mac-elcapitan (1.36 MB, application/zip) 2017-08-29 12:10 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (1.29 MB, application/zip) 2017-08-29 12:38 PDT, Build Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2017-08-29 10:17:57 PDT

Created attachment 319258 [details] patch

Build Bot

Comment 2 2017-08-29 10:18:41 PDT

Attachment 319258 [details] did not pass style-queue: ERROR: Source/WebCore/dom/Node.cpp:714: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 3 2017-08-29 10:53:16 PDT

Created attachment 319260 [details] patch

Build Bot

Comment 4 2017-08-29 10:54:21 PDT

Attachment 319260 [details] did not pass style-queue: ERROR: Source/WebCore/dom/Node.cpp:714: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 5 2017-08-29 11:57:55 PDT

Comment on attachment 319260 [details] patch Attachment 319260 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4404643 New failing tests: editing/style/apply-style-atomic.html fast/dom/HTMLElement/dynamic-editability-change.html editing/selection/user-select-all-selection.html fast/events/event-input-contentEditable.html editing/execCommand/justify-right-then-indent-with-problematic-body.html

Build Bot

Comment 6 2017-08-29 11:57:56 PDT

Created attachment 319270 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-08-29 12:09:14 PDT

Comment on attachment 319260 [details] patch Attachment 319260 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4404668 New failing tests: fast/events/event-input-contentEditable.html editing/style/apply-style-atomic.html fast/dom/HTMLElement/dynamic-editability-change.html editing/selection/user-select-all-selection.html editing/execCommand/justify-right-then-indent-with-problematic-body.html editing/selection/4895428-4.html

Build Bot

Comment 8 2017-08-29 12:09:16 PDT

Created attachment 319271 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 9 2017-08-29 12:10:10 PDT

Comment on attachment 319260 [details] patch Attachment 319260 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4404713 New failing tests: fast/events/event-input-contentEditable.html editing/style/apply-style-atomic.html fast/dom/HTMLElement/dynamic-editability-change.html editing/selection/user-select-all-selection.html editing/execCommand/justify-right-then-indent-with-problematic-body.html editing/selection/4895428-4.html

Build Bot

Comment 10 2017-08-29 12:10:12 PDT

Created attachment 319272 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 11 2017-08-29 12:38:14 PDT

Comment on attachment 319260 [details] patch Attachment 319260 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4404736 New failing tests: editing/style/apply-style-atomic.html fast/dom/HTMLElement/dynamic-editability-change.html editing/execCommand/justify-right-then-indent-with-problematic-body.html

Build Bot

Comment 12 2017-08-29 12:38:16 PDT

Created attachment 319273 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Note You need to log in before you can comment on or make changes to this bug.