Bug 176056

Summary: [Win] A WTF test is timing out in run-api-tests.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: Tools / TestsAssignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, lforschler, sabouhallawa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=195161
Attachments:
Description Flags
Patch
bfulgham: review+, bfulgham: commit-queue-
Patch none

Per Arne Vollan
Reported 2017-08-29 09:49:01 PDT
Tests that timed out: WTF_SynchronizedFixedQueue.ProduceOnly
Attachments
Patch (1.72 KB, patch)
2017-08-29 10:03 PDT, Per Arne Vollan 		bfulgham: review+
bfulgham: commit-queue-
DetailsFormatted DiffDiff
Patch (1.86 KB, patch)
2017-08-29 11:05 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2017-08-29 10:03:20 PDT
Created attachment 319257 [details] Patch
Brent Fulgham
Comment 2 2017-08-29 10:49:38 PDT
Comment on attachment 319257 [details] Patch I think we should use a conditional here so we don't allow millisecond-accurate platforms to regress. #if PLATFORM(WIN) auto sleepAmount = std::chrono::milliseconds(20); #else auto sleepAmount = std::chrono::milliseconds(10); #endif
Per Arne Vollan
Comment 3 2017-08-29 10:58:52 PDT
(In reply to Brent Fulgham from comment #2) > Comment on attachment 319257 [details] > Patch > > I think we should use a conditional here so we don't allow > millisecond-accurate platforms to regress. > > #if PLATFORM(WIN) > auto sleepAmount = std::chrono::milliseconds(20); > #else > auto sleepAmount = std::chrono::milliseconds(10); > #endif Thanks for reviewing! I will update the patch before landing.
Per Arne Vollan
Comment 4 2017-08-29 11:05:10 PDT
Created attachment 319262 [details] Patch
Per Arne Vollan
Comment 5 2017-08-29 11:36:31 PDT
Committed r221307: <https://trac.webkit.org/changeset/221307/webkit>
Radar WebKit Bug Importer
Comment 6 2017-08-29 11:37:22 PDT
<rdar://problem/34137707>
Note You need to log in before you can comment on or make changes to this bug.