Bug 176042

Summary: [CMake] Use find_package for libxml2 and libxstl
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, commit-queue, lforschler, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Don Olmstead 2017-08-28 18:04:04 PDT
Should use find_package for libxml2 and libxslt.
Comment 1 Don Olmstead 2017-08-28 18:07:17 PDT
Created attachment 319224 [details]
Patch
Comment 2 Konstantin Tokarev 2017-08-29 07:51:38 PDT
Comment on attachment 319224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319224&action=review

> Source/WebCore/CMakeLists.txt:137
> +    ${LIBXSLT_INCLUDE_DIR}

Please use alphabetic sorting in such lists wherever possible
Comment 3 Don Olmstead 2017-08-29 07:56:30 PDT
(In reply to Konstantin Tokarev from comment #2)
> Comment on attachment 319224 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=319224&action=review
> 
> > Source/WebCore/CMakeLists.txt:137
> > +    ${LIBXSLT_INCLUDE_DIR}
> 
> Please use alphabetic sorting in such lists wherever possible

They're all sorted XML is before XSLT
Comment 4 Konstantin Tokarev 2017-08-29 08:05:03 PDT
Comment on attachment 319224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319224&action=review

>>> Source/WebCore/CMakeLists.txt:137
>>> +    ${LIBXSLT_INCLUDE_DIR}
>> 
>> Please use alphabetic sorting in such lists wherever possible
> 
> They're all sorted XML is before XSLT

I've meant S goes after L
Comment 5 Don Olmstead 2017-08-29 11:23:13 PDT
Created attachment 319265 [details]
Patch

Fixed review comments.
Comment 6 Don Olmstead 2017-08-29 13:24:36 PDT
Comment on attachment 319265 [details]
Patch

Issue with WPE seems to be unrelated to this change.
Comment 7 WebKit Commit Bot 2017-08-29 13:53:05 PDT
Comment on attachment 319265 [details]
Patch

Clearing flags on attachment: 319265

Committed r221309: <http://trac.webkit.org/changeset/221309>
Comment 8 WebKit Commit Bot 2017-08-29 13:53:07 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-08-29 13:53:56 PDT
<rdar://problem/34141433>