Bug 176030

Summary: Layout test http/tests/websocket/tests/hybi/send-object-tostring-check.html is flaky
Product: WebKit Reporter: Matt Lewis <jlewis3>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: REOPENED    
Severity: Normal CC: achristensen, ap, ayumi_kojima, commit-queue, repstein, ryanhaddad, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Update Test Expectations none

Matt Lewis
Reported 2017-08-28 11:59:44 PDT
http/tests/websocket/tests/hybi/send-object-tostring-check.html is a flaky failure on multiple WK2 platforms according to the flakiness dashboard. More specifically it shows the test is flaky on iOS WK2 and El Capitan WK2 Debug. The test failed once on Sierra WK2 Release. History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fsend-object-tostring-check.html current build: https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r221258%20(2749)/results.html Diff: --- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/http/tests/websocket/tests/hybi/send-object-tostring-check-expected.txt +++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/http/tests/websocket/tests/hybi/send-object-tostring-check-actual.txt @@ -1,9 +1,11 @@ +CONSOLE MESSAGE: WebSocket network error: The operation couldn’t be completed. Connection reset by peer +CONSOLE MESSAGE: WebSocket network error: The operation couldn’t be completed. Connection reset by peer WebSocket: Object's toString method should be called only once. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". PASS testObj.callCounter is 1 -PASS closeEvent.wasClean is true +FAIL closeEvent.wasClean should be true. Was false. PASS successfullyParsed is true TEST COMPLETE
Attachments
Patch (2.28 KB, patch)
2019-06-18 14:59 PDT, Russell Epstein 		no flags
DetailsFormatted DiffDiff
Patch (2.28 KB, patch)
2019-06-18 15:05 PDT, Russell Epstein 		no flags
DetailsFormatted DiffDiff
Update Test Expectations (2.43 KB, patch)
2019-06-18 15:12 PDT, Russell Epstein 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Russell Epstein
Comment 1 2019-06-18 14:50:24 PDT
This is still happening as of 246561 with the same diff on Mac Debug WK2 and iOS WK2. History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fsend-object-tostring-check.html Diff: @@ -1,9 +1,11 @@ +CONSOLE MESSAGE: WebSocket network error: The operation couldn’t be completed. Connection reset by peer +CONSOLE MESSAGE: WebSocket network error: The operation couldn’t be completed. Connection reset by peer WebSocket: Object's toString method should be called only once. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". PASS testObj.callCounter is 1 -PASS closeEvent.wasClean is true +FAIL closeEvent.wasClean should be true. Was false. PASS successfullyParsed is true TEST COMPLETE
Russell Epstein
Comment 2 2019-06-18 14:59:05 PDT
Created attachment 372388 [details] Patch
Russell Epstein
Comment 3 2019-06-18 15:05:00 PDT
Created attachment 372389 [details] Patch
Russell Epstein
Comment 4 2019-06-18 15:12:12 PDT
Created attachment 372390 [details] Update Test Expectations
WebKit Commit Bot
Comment 5 2019-06-18 15:31:34 PDT
Comment on attachment 372390 [details] Update Test Expectations Clearing flags on attachment: 372390 Committed r246574: <https://trac.webkit.org/changeset/246574>
WebKit Commit Bot
Comment 6 2019-06-18 15:31:36 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-06-18 15:32:22 PDT
<rdar://problem/51869153>
Russell Epstein
Comment 8 2019-06-18 15:36:31 PDT
Marked test as flakey in https://trac.webkit.org/changeset/246574/webkit
Truitt Savell
Comment 9 2019-06-18 15:41:28 PDT
Reopening for investigation.
ayumi_kojima
Comment 10 2021-10-29 10:50:21 PDT
The test marked pass/fail on iOS here is now flaky timing out. Updated expectations https://trac.webkit.org/changeset/285040/webkit
Note You need to log in before you can comment on or make changes to this bug.