Summary: | [PAL] Fix "None" suffix in PAL | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yoshiaki Jitsukawa <yoshiaki.jitsukawa> | ||||||||||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | achristensen, buildbot, commit-queue, don.olmstead, mmaxfield, rniwa, webkit-bug-importer, yoshiaki.jitsukawa | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Created attachment 319165 [details]
Patch
This patch renames KillRingNone.cpp to KillRing.cpp and SoundNone.cpp to Sound.cpp and also fixes relevant Xcode and Cmake files.
Comment on attachment 319165 [details] Patch Attachment 319165 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4395878 New failing tests: editing/pasteboard/emacs-killring-alternating-append-prepend.html editing/pasteboard/emacs-ctrl-a-k-y.html editing/pasteboard/emacs-ctrl-k-y-001.html editing/pasteboard/emacs-ctrl-k-with-move.html editing/pasteboard/emacs-killring-backward-delete-prepend.html Created attachment 319167 [details]
Archive of layout-test-results from ews101 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 319165 [details] Patch Attachment 319165 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4395881 New failing tests: editing/pasteboard/emacs-killring-alternating-append-prepend.html editing/pasteboard/emacs-ctrl-a-k-y.html editing/pasteboard/emacs-killring-backward-delete-prepend.html editing/pasteboard/emacs-ctrl-k-with-move.html Created attachment 319168 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 319165 [details] Patch Attachment 319165 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4395918 New failing tests: editing/pasteboard/emacs-killring-alternating-append-prepend.html editing/pasteboard/emacs-ctrl-a-k-y.html editing/pasteboard/emacs-ctrl-k-y-001.html editing/pasteboard/emacs-ctrl-k-with-move.html editing/pasteboard/emacs-killring-backward-delete-prepend.html Created attachment 319171 [details]
Archive of layout-test-results from ews112 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 319174 [details]
Patch
Created attachment 319405 [details]
Patch
Did you mean to mark this patch as "r?"? (In reply to Myles C. Maxfield from comment #10) > Did you mean to mark this patch as "r?"? Ah, yes. Thank you! Comment on attachment 319405 [details] Patch Clearing flags on attachment: 319405 Committed r221405: <http://trac.webkit.org/changeset/221405> All reviewed patches have been landed. Closing bug. |
I'm trying to rename *None.cpp to *.cpp, based on the suggestion given in "[webkit-dev] None Suffix in PAL": > I'd suggest not having any suffix when it's empty stub and suffix it with Generic when it's a generic implementation some platforms in the accordance with the existing convention.