Bug 176014

Summary: [PAL] Fix "None" suffix in PAL
Product: WebKit Reporter: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, commit-queue, don.olmstead, mmaxfield, rniwa, webkit-bug-importer, yoshiaki.jitsukawa
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-elcapitan
none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews112 for mac-elcapitan
none
Patch
none
Patch none

Description Yoshiaki Jitsukawa 2017-08-28 00:10:52 PDT
I'm trying to rename *None.cpp to *.cpp, based on the suggestion given in "[webkit-dev] None Suffix in PAL":
> I'd suggest not having any suffix when it's empty stub and suffix it with Generic when it's a generic implementation some platforms in the accordance with the existing convention.
Comment 1 Yoshiaki Jitsukawa 2017-08-28 00:19:43 PDT
Created attachment 319165 [details]
Patch

This patch renames KillRingNone.cpp to KillRing.cpp and SoundNone.cpp to Sound.cpp and also fixes relevant Xcode and Cmake files.
Comment 2 Build Bot 2017-08-28 01:26:26 PDT
Comment on attachment 319165 [details]
Patch

Attachment 319165 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4395878

New failing tests:
editing/pasteboard/emacs-killring-alternating-append-prepend.html
editing/pasteboard/emacs-ctrl-a-k-y.html
editing/pasteboard/emacs-ctrl-k-y-001.html
editing/pasteboard/emacs-ctrl-k-with-move.html
editing/pasteboard/emacs-killring-backward-delete-prepend.html
Comment 3 Build Bot 2017-08-28 01:26:27 PDT
Created attachment 319167 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-08-28 01:30:36 PDT
Comment on attachment 319165 [details]
Patch

Attachment 319165 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4395881

New failing tests:
editing/pasteboard/emacs-killring-alternating-append-prepend.html
editing/pasteboard/emacs-ctrl-a-k-y.html
editing/pasteboard/emacs-killring-backward-delete-prepend.html
editing/pasteboard/emacs-ctrl-k-with-move.html
Comment 5 Build Bot 2017-08-28 01:30:38 PDT
Created attachment 319168 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-08-28 02:02:23 PDT
Comment on attachment 319165 [details]
Patch

Attachment 319165 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4395918

New failing tests:
editing/pasteboard/emacs-killring-alternating-append-prepend.html
editing/pasteboard/emacs-ctrl-a-k-y.html
editing/pasteboard/emacs-ctrl-k-y-001.html
editing/pasteboard/emacs-ctrl-k-with-move.html
editing/pasteboard/emacs-killring-backward-delete-prepend.html
Comment 7 Build Bot 2017-08-28 02:02:25 PDT
Created attachment 319171 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 Yoshiaki Jitsukawa 2017-08-28 04:36:19 PDT
Created attachment 319174 [details]
Patch
Comment 9 Yoshiaki Jitsukawa 2017-08-30 14:38:26 PDT
Created attachment 319405 [details]
Patch
Comment 10 Myles C. Maxfield 2017-08-30 15:25:06 PDT
Did you mean to mark this patch as "r?"?
Comment 11 Yoshiaki Jitsukawa 2017-08-30 15:39:52 PDT
(In reply to Myles C. Maxfield from comment #10)
> Did you mean to mark this patch as "r?"?

Ah, yes. Thank you!
Comment 12 WebKit Commit Bot 2017-08-30 16:03:55 PDT
Comment on attachment 319405 [details]
Patch

Clearing flags on attachment: 319405

Committed r221405: <http://trac.webkit.org/changeset/221405>
Comment 13 WebKit Commit Bot 2017-08-30 16:03:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 14 Radar WebKit Bug Importer 2017-08-30 16:05:14 PDT
<rdar://problem/34174920>