Bug 176011

Summary: [iOS WK2] Web process crashes after changing selection to the end of the document when speaking a selection
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: AccessibilityAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: cfleizach, commit-queue, n_wang, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
rniwa: review+
Patch for landing none

Wenson Hsieh
Reported 2017-08-26 23:40:43 PDT
<rdar://problem/32614095>
Attachments
Patch (23.47 KB, patch)
2017-08-27 00:05 PDT, Wenson Hsieh 		rniwa: review+
DetailsFormatted DiffDiff
Patch for landing (23.00 KB, patch)
2017-08-27 17:41 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2017-08-27 00:05:41 PDT
Created attachment 319156 [details] Patch
Ryosuke Niwa
Comment 2 2017-08-27 16:49:46 PDT
Comment on attachment 319156 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319156&action=review > Source/WebCore/editing/Editing.cpp:1095 > +VisiblePosition visiblePositionForPositionWithOffset(const VisiblePosition& position, int32_t offset) We should make this function take unsigned instead of int32_t. It's non-sensical to have a negative offset.
Wenson Hsieh
Comment 3 2017-08-27 16:55:30 PDT
Comment on attachment 319156 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319156&action=review >> Source/WebCore/editing/Editing.cpp:1095 >> +VisiblePosition visiblePositionForPositionWithOffset(const VisiblePosition& position, int32_t offset) > > We should make this function take unsigned instead of int32_t. It's non-sensical to have a negative offset. Sounds good! Changed to unsigned.
Wenson Hsieh
Comment 4 2017-08-27 17:13:10 PDT
Comment on attachment 319156 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319156&action=review >>> Source/WebCore/editing/Editing.cpp:1095 >>> +VisiblePosition visiblePositionForPositionWithOffset(const VisiblePosition& position, int32_t offset) >> >> We should make this function take unsigned instead of int32_t. It's non-sensical to have a negative offset. > > Sounds good! Changed to unsigned. Actually, a call site of visiblePositionForPositionWithOffset in AXObjectCache.cpp takes in a negative integer -- we'll change this to be an int instead.
Wenson Hsieh
Comment 5 2017-08-27 17:41:09 PDT
Created attachment 319163 [details] Patch for landing
WebKit Commit Bot
Comment 6 2017-08-27 18:22:59 PDT
Comment on attachment 319163 [details] Patch for landing Clearing flags on attachment: 319163 Committed r221233: <http://trac.webkit.org/changeset/221233>
Note You need to log in before you can comment on or make changes to this bug.