Bug 175987
| Summary: | Manage tests which require different device types better | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ap, lforschler, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=176962 | ||
Jonathan Bedard
There are a number of problems with layout tests which require different device types. Currently, iOS Simulator test runs handle this by running the test suite first with 5s devices, then with iPads and then with iPhone 7s. This is super inefficient since we boot up an entire new queue of devices (on our bots, this means 12 devices) to run maybe a half-dozen to two-dozen tests. When running layout tests on actual iOS devices, the problem is even worse. Currently, we need to skip any device specific test no mater what type of device is connected. We need to re-factor the way we handle these types of tests.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/34082632>
Jonathan Bedard
Gardened test for on-device testing in <https://trac.webkit.org/changeset/221188/webkit>.
Jonathan Bedard
We implemented this when implementing better support for iPad testing.