Bug 175972

Summary:

[WinCairo] Use GitHub releases for WinCairoRequirements

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

Tools / Tests

Assignee:

Don Olmstead <don.olmstead>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, annulen, bburg, bfulgham, buildbot, commit-queue, lforschler, pvollan, ross.kirsling, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Don Olmstead

Reported 2017-08-24 18:48:09 PDT

Now that there is a script which will download a GitHub release package it should be used instead of the original perl script.

Attachments
Patch (6.27 KB, patch) 2017-08-24 18:58 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (6.38 KB, patch) 2017-08-24 19:33 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (6.31 KB, patch) 2017-08-24 19:40 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Don Olmstead

Comment 1 2017-08-24 18:58:25 PDT

Created attachment 319053 [details] Patch This uses download-latest-github-release.py to get the latest WinCairoRequirements.

Build Bot

Comment 2 2017-08-24 18:59:33 PDT

Attachment 319053 [details] did not pass style-queue: ERROR: Tools/Scripts/download-latest-github-release.py:48: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Tools/Scripts/download-latest-github-release.py:106: [main] Undefined variable 'ERROR' [pylint/E0602] [5] ERROR: Tools/Scripts/download-latest-github-release.py:129: Undefined variable 'ERROR' [pylint/E0602] [5] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Don Olmstead

Comment 3 2017-08-24 19:33:08 PDT

Created attachment 319058 [details] Patch Fix style

Build Bot

Comment 4 2017-08-24 19:35:08 PDT

Attachment 319058 [details] did not pass style-queue: ERROR: Tools/Scripts/download-latest-github-release.py:44: expected 2 blank lines, found 1 [pep8/E302] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Don Olmstead

Comment 5 2017-08-24 19:40:30 PDT

Created attachment 319060 [details] Patch Fix logic error

Don Olmstead

Comment 6 2017-08-24 19:45:25 PDT

Comment on attachment 319060 [details] Patch Modified download-latest-github-release.py so it can be imported and used from the script directly. This means the update-webkit-wincairo-libs doesn't have to keep track of whether the file was updated. Also Removed the old perl implementation.

Don Olmstead

Comment 7 2017-08-24 19:47:23 PDT

This should fix the WinCairo builds as the referenced repository has the sqlite files staged so CMake will pick them up.

Brent Fulgham

Comment 8 2017-08-25 09:25:56 PDT

Comment on attachment 319060 [details] Patch Nice! r=me.

WebKit Commit Bot

Comment 9 2017-08-25 10:23:24 PDT

Comment on attachment 319060 [details] Patch Clearing flags on attachment: 319060 Committed r221191: <http://trac.webkit.org/changeset/221191>

WebKit Commit Bot

Comment 10 2017-08-25 10:23:25 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 11 2017-08-25 10:24:34 PDT

<rdar://problem/34083805>

Note You need to log in before you can comment on or make changes to this bug.