Bug 175960

Summary:

Fix build breakage with Public iOS 11 SDK

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, lforschler, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Jonathan Bedard 2017-08-24 15:57:34 PDT

Currently, there are some build issues when building tip of tree WebKit with the public iOS 11 SDK.

Comment 1 Radar WebKit Bug Importer 2017-08-24 15:58:02 PDT

<rdar://problem/34069264>

Comment 2 Jonathan Bedard 2017-08-24 16:05:49 PDT

Created attachment 319032 [details]
Patch

Comment 3 Wenson Hsieh 2017-08-24 16:09:32 PDT

Comment on attachment 319032 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319032&action=review

> Tools/TestWebKitAPI/ios/DataInteractionSimulator.h:93
> +@interface UIItemProvider : NSItemProvider

<UIKit/NSItemProvider+UIKitAdditions.h> appears to be public in the latest SDK, and that defines preferredPresentationSize on NSItemProvider (which UIItemProvider subclasses). Can we just import that header instead?

Comment 4 Jonathan Bedard 2017-08-24 16:15:34 PDT

(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 319032 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=319032&action=review
> 
> > Tools/TestWebKitAPI/ios/DataInteractionSimulator.h:93
> > +@interface UIItemProvider : NSItemProvider
> 
> <UIKit/NSItemProvider+UIKitAdditions.h> appears to be public in the latest
> SDK, and that defines preferredPresentationSize on NSItemProvider (which
> UIItemProvider subclasses). Can we just import that header instead?

Then we need to change that in UIKitSPI.h as well.

Comment 5 Wenson Hsieh 2017-08-24 16:44:58 PDT

(In reply to Jonathan Bedard from comment #4)
> (In reply to Wenson Hsieh from comment #3)
> > Comment on attachment 319032 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=319032&action=review
> > 
> > > Tools/TestWebKitAPI/ios/DataInteractionSimulator.h:93
> > > +@interface UIItemProvider : NSItemProvider
> > 
> > <UIKit/NSItemProvider+UIKitAdditions.h> appears to be public in the latest
> > SDK, and that defines preferredPresentationSize on NSItemProvider (which
> > UIItemProvider subclasses). Can we just import that header instead?
> 
> Then we need to change that in UIKitSPI.h as well.

Yep, that would be ideal!

Comment 6 Jonathan Bedard 2017-08-24 16:47:32 PDT

Created attachment 319035 [details]
Patch

Comment 7 WebKit Commit Bot 2017-08-25 08:27:25 PDT

Comment on attachment 319035 [details]
Patch

Clearing flags on attachment: 319035

Committed r221187: <http://trac.webkit.org/changeset/221187>

Comment 8 WebKit Commit Bot 2017-08-25 08:27:26 PDT

All reviewed patches have been landed.  Closing bug.

Comment 9 Jonathan Bedard 2017-08-25 11:55:12 PDT

Follow-up fix in <http://trac.webkit.org/changeset/221197>