Bug 175960 - Fix build breakage with Public iOS 11 SDK
Summary: Fix build breakage with Public iOS 11 SDK
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-24 15:57 PDT by Jonathan Bedard
Modified: 2017-08-25 11:55 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.43 KB, patch)
2017-08-24 16:05 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (4.34 KB, patch)
2017-08-24 16:47 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2017-08-24 15:57:34 PDT 
Currently, there are some build issues when building tip of tree WebKit with the public iOS 11 SDK.
Comment 1 Radar WebKit Bug Importer 2017-08-24 15:58:02 PDT 
<rdar://problem/34069264>
Comment 2 Jonathan Bedard 2017-08-24 16:05:49 PDT 
Created attachment 319032 [details]
Patch
Comment 3 Wenson Hsieh 2017-08-24 16:09:32 PDT 
Comment on attachment 319032 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319032&action=review

> Tools/TestWebKitAPI/ios/DataInteractionSimulator.h:93
> +@interface UIItemProvider : NSItemProvider

<UIKit/NSItemProvider+UIKitAdditions.h> appears to be public in the latest SDK, and that defines preferredPresentationSize on NSItemProvider (which UIItemProvider subclasses). Can we just import that header instead?
Comment 4 Jonathan Bedard 2017-08-24 16:15:34 PDT 
(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 319032 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=319032&action=review
> 
> > Tools/TestWebKitAPI/ios/DataInteractionSimulator.h:93
> > +@interface UIItemProvider : NSItemProvider
> 
> <UIKit/NSItemProvider+UIKitAdditions.h> appears to be public in the latest
> SDK, and that defines preferredPresentationSize on NSItemProvider (which
> UIItemProvider subclasses). Can we just import that header instead?

Then we need to change that in UIKitSPI.h as well.
Comment 5 Wenson Hsieh 2017-08-24 16:44:58 PDT 
(In reply to Jonathan Bedard from comment #4)
> (In reply to Wenson Hsieh from comment #3)
> > Comment on attachment 319032 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=319032&action=review
> > 
> > > Tools/TestWebKitAPI/ios/DataInteractionSimulator.h:93
> > > +@interface UIItemProvider : NSItemProvider
> > 
> > <UIKit/NSItemProvider+UIKitAdditions.h> appears to be public in the latest
> > SDK, and that defines preferredPresentationSize on NSItemProvider (which
> > UIItemProvider subclasses). Can we just import that header instead?
> 
> Then we need to change that in UIKitSPI.h as well.

Yep, that would be ideal!
Comment 6 Jonathan Bedard 2017-08-24 16:47:32 PDT 
Created attachment 319035 [details]
Patch
Comment 7 WebKit Commit Bot 2017-08-25 08:27:25 PDT 
Comment on attachment 319035 [details]
Patch

Clearing flags on attachment: 319035

Committed r221187: <http://trac.webkit.org/changeset/221187>
Comment 8 WebKit Commit Bot 2017-08-25 08:27:26 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Jonathan Bedard 2017-08-25 11:55:12 PDT 
Follow-up fix in <http://trac.webkit.org/changeset/221197>