Bug 175951

Summary: Web Inspector: Views should explicitly remove event listeners from managers/Frame
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Ross Kirsling
Reported 2017-08-24 12:55:41 PDT
(Based on an IRC conversation with JoePeck.) Although some views have a single persistent instance, ideally any event listeners attached to managers and the like should still be cleaned up in closed().
Attachments
Patch (8.31 KB, patch)
2017-08-24 13:39 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (8.53 KB, patch)
2017-10-10 11:43 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2017-08-24 13:39:47 PDT
Created attachment 319015 [details] Patch
Blaze Burg
Comment 2 2017-10-09 11:32:06 PDT
Comment on attachment 319015 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319015&action=review r=me. Please rebase and upload a new patch to EWS before landing. > Source/WebInspectorUI/UserInterface/Views/QuickConsole.js:106 > + Technically outside the scope of this patch, but this should also unregister from WI.consoleDrawer and WI.TabBrowser.
Ross Kirsling
Comment 3 2017-10-10 11:43:01 PDT
Created attachment 323327 [details] Patch
WebKit Commit Bot
Comment 4 2017-10-10 12:24:07 PDT
Comment on attachment 323327 [details] Patch Clearing flags on attachment: 323327 Committed r223137: <http://trac.webkit.org/changeset/223137>
WebKit Commit Bot
Comment 5 2017-10-10 12:24:08 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-10-10 12:25:31 PDT
<rdar://problem/34916512>
Note You need to log in before you can comment on or make changes to this bug.