Bug 175922

Summary: [iOS] ViewServices started by StoreKitUIService may get suspended unexpectedly
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aestes, beidson, commit-queue, ggaren, sam, thorton, webkit-bug-importer, yongjun_zhang
Priority: P1 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2017-08-23 20:11:35 PDT
ViewServices started by StoreKitUIService may get suspended unexpectedly.
Attachments
Patch (3.14 KB, patch)
2017-08-23 20:16 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-08-23 20:11:57 PDT
<rdar://problem/34028921>
Chris Dumez
Comment 2 2017-08-23 20:16:12 PDT
Created attachment 318962 [details] Patch
Tim Horton
Comment 3 2017-08-24 00:14:43 PDT
Comment on attachment 318962 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318962&action=review > Source/WebKit/UIProcess/ApplicationStateTracker.mm:153 > + m_isInBackground = false; Can’t they just use the WKWebViewConfiguration SPI to be treated like they’re always in the foreground, like every other instance of this?
Tim Horton
Comment 4 2017-08-24 00:18:22 PDT
Comment on attachment 318962 [details] Patch If not, please kick back for review, but it seems wrong to special case this when we already have a mechanism to handle it. If this were a generic mechanism to handle doubly-service-hosted web views, that would be a different story.
Tim Horton
Comment 5 2017-08-24 00:20:54 PDT
Specifically, I am referring to _setAlwaysRunsAtForegroundPriority:
Yongjun Zhang
Comment 6 2017-08-24 06:29:59 PDT
(In reply to Tim Horton from comment #5) > Specifically, I am referring to _setAlwaysRunsAtForegroundPriority: The host app doesn’t have access to WKWebview since it is using Safari view controller.
WebKit Commit Bot
Comment 7 2017-08-24 08:59:27 PDT
Comment on attachment 318962 [details] Patch Clearing flags on attachment: 318962 Committed r221138: <http://trac.webkit.org/changeset/221138>
WebKit Commit Bot
Comment 8 2017-08-24 08:59:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.