Summary: | Speedometer 2.0: Add the capability to run a specific suite | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | Tools / Tests | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | buildbot, cdumez, joepeck, lforschler, saam, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 172339 | ||||||||
Attachments: |
|
Description
Ryosuke Niwa
2017-08-23 14:56:20 PDT
Created attachment 318926 [details]
Adds the feature
Created attachment 318928 [details]
Updated change log
Committed r221114: <http://trac.webkit.org/changeset/221114> Comment on attachment 318928 [details] Updated change log View in context: https://bugs.webkit.org/attachment.cgi?id=318928&action=review > PerformanceTests/Speedometer/resources/main.js:160 > + if (currentSuite.name.toLowerCase() == suiteToEnable) { > + currentSuite.disabled = false; > + found = true; Can there be duplicate names? If not, then you can `return true` here instead of continuing to loop. > PerformanceTests/Speedometer/resources/main.js:168 > + var enabledSuites = Suites.filter(function (suite) { return !suite.disabled; }); This seems to be a duplicate of line 200 with no change between now and then. Seems this line can be removed. > PerformanceTests/Speedometer/resources/main.js:192 > + alert('No tests to run'); This might be more useful to include the name of the one test that no longer exists: alert('Suite "' + value + '" does not exist. No tests to run.'); (In reply to Joseph Pecoraro from comment #5) > Comment on attachment 318928 [details] > Updated change log > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318928&action=review > > > PerformanceTests/Speedometer/resources/main.js:160 > > + if (currentSuite.name.toLowerCase() == suiteToEnable) { > > + currentSuite.disabled = false; > > + found = true; > > Can there be duplicate names? If not, then you can `return true` here > instead of continuing to loop. No, but we still have to set currentSuite.disabled to true in all other suite objects. > > PerformanceTests/Speedometer/resources/main.js:168 > > + var enabledSuites = Suites.filter(function (suite) { return !suite.disabled; }); > > This seems to be a duplicate of line 200 with no change between now and > then. Seems this line can be removed. Oops, removed. > > PerformanceTests/Speedometer/resources/main.js:192 > > + alert('No tests to run'); > > This might be more useful to include the name of the one test that no longer > exists: > > alert('Suite "' + value + '" does not exist. No tests to run.'); Fixed. |