Bug 175907

Summary: Stop using PolicyCallback for new window policies
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, buildbot, cdumez, commit-queue, dbates, japhet, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
aestes: review+
patch none

Alex Christensen
Reported 2017-08-23 14:28:46 PDT
Stop using PolicyCallback for new window policies
Attachments
Patch (10.78 KB, patch)
2017-08-23 14:38 PDT, Alex Christensen 		aestes: review+
DetailsFormatted DiffDiff
patch (10.78 KB, patch)
2017-08-24 11:10 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-08-23 14:38:17 PDT
Created attachment 318922 [details] Patch
Alex Christensen
Comment 2 2017-08-23 15:11:36 PDT
I made the NavigationAction copy more explicit. http://trac.webkit.org/r221109
Ryan Haddad
Comment 3 2017-08-23 17:15:54 PDT
(In reply to Alex Christensen from comment #2) > I made the NavigationAction copy more explicit. > http://trac.webkit.org/r221109 This change introduced assertion failures on iOS and macOS: https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r221109%20(2679)/results.html https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20(Tests)/r221109%20(3496)/results.html
Radar WebKit Bug Importer
Comment 4 2017-08-23 17:16:13 PDT
<rdar://problem/34048194>
Ryan Haddad
Comment 5 2017-08-23 17:26:39 PDT
(In reply to Ryan Haddad from comment #3) > (In reply to Alex Christensen from comment #2) > > I made the NavigationAction copy more explicit. > > http://trac.webkit.org/r221109 > This change introduced assertion failures on iOS and macOS: > https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/ > r221109%20(2679)/results.html > https://build.webkit.org/results/ > Apple%20iOS%2010%20Simulator%20Debug%20WK2%20(Tests)/r221109%20(3496)/ > results.html SHOULD NEVER BE REACHED /Volumes/Data/slave/sierra-debug/build/Source/WebCore/loader/PolicyChecker.cpp(177) : auto WebCore::PolicyChecker::checkNewWindowPolicy(WebCore::NavigationAction &&, const WebCore::ResourceRequest &, WebCore::FormState *, const WTF::String &, NewWindowPolicyDecisionFunction)::(anonymous class)::operator()(WebCore::PolicyAction) const
Ryan Haddad
Comment 6 2017-08-23 17:31:27 PDT
Reverted r221109 for reason: This change caused assertion failures on iOS and macOS debug bots. Committed r221122: <http://trac.webkit.org/changeset/221122>
Alex Christensen
Comment 7 2017-08-24 11:09:21 PDT
Comment on attachment 318922 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318922&action=review > Source/WebCore/loader/PolicyChecker.cpp:171 > + break; Oops, these need to be returns.
Alex Christensen
Comment 8 2017-08-24 11:10:35 PDT
Created attachment 318998 [details] patch
WebKit Commit Bot
Comment 9 2017-08-24 14:45:42 PDT
Comment on attachment 318998 [details] patch Clearing flags on attachment: 318998 Committed r221162: <http://trac.webkit.org/changeset/221162>
WebKit Commit Bot
Comment 10 2017-08-24 14:45:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.