Bug 175902

Summary: [Cache API] Unify WebCore and WebKit error handling
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, cdumez, cgarcia, commit-queue, ggaren, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch - windows fix none

Description youenn fablet 2017-08-23 13:20:47 PDT 
We should use more expected and have a single error enumeration.
Comment 1 youenn fablet 2017-08-23 13:35:45 PDT 
Created attachment 318911 [details]
Patch
Comment 2 youenn fablet 2017-08-23 14:15:27 PDT 
Created attachment 318917 [details]
Patch
Comment 3 Build Bot 2017-08-23 14:18:18 PDT 
Attachment 318917 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/cache/DOMCache.h:48:  The parameter name "request" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 youenn fablet 2017-08-23 14:30:18 PDT 
Created attachment 318919 [details]
Patch
Comment 5 Build Bot 2017-08-23 14:32:43 PDT 
Attachment 318919 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/cache/DOMCache.h:48:  The parameter name "request" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 WebKit Commit Bot 2017-08-23 15:33:19 PDT 
Comment on attachment 318919 [details]
Patch

Clearing flags on attachment: 318919

Committed r221112: <http://trac.webkit.org/changeset/221112>
Comment 7 WebKit Commit Bot 2017-08-23 15:33:21 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-08-23 15:34:19 PDT 
<rdar://problem/34045933>
Comment 9 Ryan Haddad 2017-08-23 16:08:52 PDT 
(In reply to WebKit Commit Bot from comment #6)
> Comment on attachment 318919 [details]
> Patch
> 
> Clearing flags on attachment: 318919
> 
> Committed r221112: <http://trac.webkit.org/changeset/221112>
This change broke the Windows build: https://build.webkit.org/builders/Apple%20Win%20Release%20(Build)/builds/3884
Comment 10 youenn fablet 2017-08-23 17:07:41 PDT 
Reopening to attach new patch.
Comment 11 youenn fablet 2017-08-23 17:07:42 PDT 
Created attachment 318942 [details]
Patch - windows fix
Comment 12 WebKit Commit Bot 2017-08-23 17:39:27 PDT 
Comment on attachment 318942 [details]
Patch - windows fix

Clearing flags on attachment: 318942

Committed r221123: <http://trac.webkit.org/changeset/221123>
Comment 13 WebKit Commit Bot 2017-08-23 17:39:28 PDT 
All reviewed patches have been landed.  Closing bug.