| Summary: | Add WKUIDelegatePrivate callbacks corresponding to WKPageUIClient's takeFocus, focus, and unfocus | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | thorton, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alex Christensen
2017-08-23 11:58:04 PDT
Created attachment 318893 [details]
Patch
Comment on attachment 318893 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318893&action=review > Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:130 > -- (void)_webViewShow:(WKWebView *)webView WK_API_AVAILABLE(macosx(WK_MAC_TBA)); > +- (void)_showWebView:(WKWebView *)webView WK_API_AVAILABLE(macosx(WK_MAC_TBA)); > +- (void)_focusWebView:(WKWebView *)webView WK_API_AVAILABLE(macosx(WK_MAC_TBA)); > +- (void)_unfocusWebView:(WKWebView *)webView WK_API_AVAILABLE(macosx(WK_MAC_TBA)); > +- (void)_webView:(WKWebView *)webView takeFocus:(_WKFocusDirection)direction WK_API_AVAILABLE(macosx(WK_MAC_TBA)); I have another question. Why are all these things Mac only? They don't seem to be, underneath. Platform-specific things should be the exception, not the rule. Created attachment 318901 [details]
Patch
(In reply to Tim Horton from comment #2) > I have another question. Why are all these things Mac only? They don't seem > to be, underneath. Platform-specific things should be the exception, not the > rule. Focus and keyboard events are quite different on iOS. _webViewShow didn't work on iOS and it's not needed. We could fix it and add it later if needed. Created attachment 318906 [details]
Patch
|