Bug 175882

Summary:

CacheStorageEngine readCachesFromDisk callback should return the read Caches

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, cdumez, cgarcia, commit-queue, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description youenn fablet 2017-08-23 08:07:14 PDT

This is more consistent with the other callbacks

Comment 1 youenn fablet 2017-08-23 08:08:49 PDT

Created attachment 318868 [details]
Patch

Comment 2 WebKit Commit Bot 2017-08-23 10:52:59 PDT

Comment on attachment 318868 [details]
Patch

Clearing flags on attachment: 318868

Committed r221085: <http://trac.webkit.org/changeset/221085>

Comment 3 WebKit Commit Bot 2017-08-23 10:53:01 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Radar WebKit Bug Importer 2017-08-23 10:53:34 PDT

<rdar://problem/34038604>

Comment 5 Saam Barati 2017-08-25 12:21:17 PDT

Comment on attachment 318868 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318868&action=review

> Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:130
> +            cachesInfo.uncheckedAppend(WebCore::CacheStorageConnection::CacheInfo { cache.identifier, cache.name});

Ned space between "e" and "}"

Comment 6 youenn fablet 2017-08-25 14:25:10 PDT

(In reply to Saam Barati from comment #5)
> Comment on attachment 318868 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=318868&action=review
> 
> > Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:130
> > +            cachesInfo.uncheckedAppend(WebCore::CacheStorageConnection::CacheInfo { cache.identifier, cache.name});
> 
> Ned space between "e" and "}"

Thanks, will fix it as part of bug 175995