RESOLVED FIXED 175882
CacheStorageEngine readCachesFromDisk callback should return the read Caches 
https://bugs.webkit.org/show_bug.cgi?id=175882
Summary CacheStorageEngine readCachesFromDisk callback should return the read Caches
youenn fablet
Reported 2017-08-23 08:07:14 PDT
This is more consistent with the other callbacks
Attachments
Patch (6.24 KB, patch)
2017-08-23 08:08 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-08-23 08:08:49 PDT
Created attachment 318868 [details] Patch
WebKit Commit Bot
Comment 2 2017-08-23 10:52:59 PDT
Comment on attachment 318868 [details] Patch Clearing flags on attachment: 318868 Committed r221085: <http://trac.webkit.org/changeset/221085>
WebKit Commit Bot
Comment 3 2017-08-23 10:53:01 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2017-08-23 10:53:34 PDT
<rdar://problem/34038604>
Saam Barati
Comment 5 2017-08-25 12:21:17 PDT
Comment on attachment 318868 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318868&action=review > Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:130 > + cachesInfo.uncheckedAppend(WebCore::CacheStorageConnection::CacheInfo { cache.identifier, cache.name}); Ned space between "e" and "}"
youenn fablet
Comment 6 2017-08-25 14:25:10 PDT
(In reply to Saam Barati from comment #5) > Comment on attachment 318868 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318868&action=review > > > Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:130 > > + cachesInfo.uncheckedAppend(WebCore::CacheStorageConnection::CacheInfo { cache.identifier, cache.name}); > > Ned space between "e" and "}" Thanks, will fix it as part of bug 175995
Note You need to log in before you can comment on or make changes to this bug.