Bug 175853

Summary: [Win] Compile error, include file <wtf/AVFoundationHeaderDetection.h> is not found.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: Web Template FrameworkAssignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Per Arne Vollan
Reported 2017-08-22 15:09:12 PDT
wtf/Platform.h(1071): fatal error C1083: Cannot open include file: 'wtf/AVFoundationHeaderDetection.h': No such file or directory. This happens when building WebKit from the .proj files.
Attachments
Patch (2.45 KB, patch)
2017-08-22 15:19 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2017-08-22 15:10:04 PDT
<rdar://problem/33960828>
Per Arne Vollan
Comment 2 2017-08-22 15:19:22 PDT
Created attachment 318805 [details] Patch
Brent Fulgham
Comment 3 2017-08-22 15:20:36 PDT
Comment on attachment 318805 [details] Patch I think this may also fix my new build failure caused by using another WTF file in WebCore builds. r=me if EWS passes.
Per Arne Vollan
Comment 4 2017-08-22 15:30:05 PDT
(In reply to Brent Fulgham from comment #3) > Comment on attachment 318805 [details] > Patch > > I think this may also fix my new build failure caused by using another WTF > file in WebCore builds. r=me if EWS passes. Thanks for reviewing, Brent! Also, it seems to me that the file preBuild.cmd in WTF is not executed. Is this relevant to the build errors we are seeing?
Brent Fulgham
Comment 5 2017-08-22 15:33:31 PDT
(In reply to Per Arne Vollan from comment #4) > (In reply to Brent Fulgham from comment #3) > > Comment on attachment 318805 [details] > > Patch > > > > I think this may also fix my new build failure caused by using another WTF > > file in WebCore builds. r=me if EWS passes. > > Thanks for reviewing, Brent! > > Also, it seems to me that the file preBuild.cmd in WTF is not executed. Is > this relevant to the build errors we are seeing? Yes, I think so. Though I realize now that your change was only about the *.proj file, so not really relevant here. Can you try doing a clean build and see if you hit the error? I believe the FORWARDING_HEADERS are not getting copied (since that script no longer runs) causing build failures.
WebKit Commit Bot
Comment 6 2017-08-23 09:21:46 PDT
Comment on attachment 318805 [details] Patch Clearing flags on attachment: 318805 Committed r221076: <http://trac.webkit.org/changeset/221076>
WebKit Commit Bot
Comment 7 2017-08-23 09:21:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.