Bug 175827

Summary: Add sanity check for source origin in WebLoaderStrategy::startPingLoad()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: REOPENED    
Severity: Normal CC: commit-queue, ggaren, ryanhaddad, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2017-08-22 10:24:43 PDT
Add sanity check for source origin in WebLoaderStrategy::startPingLoad().
Attachments
Patch (2.29 KB, patch)
2017-08-22 10:26 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.36 KB, patch)
2017-08-22 10:34 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-08-22 10:26:10 PDT
Created attachment 318762 [details] Patch
Geoffrey Garen
Comment 2 2017-08-22 10:29:56 PDT
Comment on attachment 318762 [details] Patch r=me
youenn fablet
Comment 3 2017-08-22 10:31:25 PDT
Origin header might not always be there for same-origin requests.
Chris Dumez
Comment 4 2017-08-22 10:34:28 PDT
Created attachment 318763 [details] Patch
WebKit Commit Bot
Comment 5 2017-08-22 11:16:43 PDT
Comment on attachment 318763 [details] Patch Clearing flags on attachment: 318763 Committed r221027: <http://trac.webkit.org/changeset/221027>
WebKit Commit Bot
Comment 6 2017-08-22 11:16:45 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-08-22 11:17:31 PDT
<rdar://problem/34016866>
Ryan Haddad
Comment 8 2017-08-22 13:53:24 PDT
Reverted r221027 for reason: This change caused LayoutTests to exit early with assertion failures. Committed r221043: <http://trac.webkit.org/changeset/221043>
Ryan Haddad
Comment 9 2017-08-22 13:54:00 PDT
(In reply to Ryan Haddad from comment #8) > Reverted r221027 for reason: > > This change caused LayoutTests to exit early with assertion failures. > > Committed r221043: <http://trac.webkit.org/changeset/221043> Relevant link: https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r221029%20(2653)/results.html
Note You need to log in before you can comment on or make changes to this bug.