Bug 175813 – Performance Dashboard should be compatible with PHP 7.

• Component: New Bugs
• Status: NEW

Performance Dashboard should be compatible with PHP 7.

Created attachment 318739 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 318739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318739&action=review

r- because I don't think we should be asking people to override config.json like this.

> Websites/perf.webkit.org/ReadMe.md:52
> +(If you have a PHP 7 installed, please make sure `phpVersion` in `config.json` is updated to 'PHP7', by default it's 'PHP5'.
> +)

I don't think should force everyone to manually edit JSON like this.

> Websites/perf.webkit.org/config.json:27
> +        "httpdMutexDir": "/tmp/org.webkit.perf.tests/",
> +        "phpVersion": "PHP5"

Instead of specifying PHP version like that, we should just pick the right module based on the result of php -v.

> Websites/perf.webkit.org/server-tests/resources/test-server.js:173
> +        let phpVersion = Config.value('testServer.phpVersion');

Just do: ChildProcess.execFileSync('php', ['-v']).includes('PHP 5') ? 'PHP5' : 'PHP7';

Created attachment 318806 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 318806 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318806&action=review

> Websites/perf.webkit.org/tools/remote-server-relay.conf:66
> +<IfModule php5_module>

Change this to php7_module.

[Build Bot]

Comment on attachment 318806 [details]
Patch

Attachment 318806 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4364601

New failing tests:
media/track/track-element-load-event.html

[Build Bot]

Created attachment 318831 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6