Bug 175811 – Speedometer 2.0: Make it possible to change the iteration count via query string

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Ryosuke Niwa]

Make it possible to change the iteration count of Speedometer via query string.
Also reduce the default iteration count from 20 to 10.

[Ryosuke Niwa]

Created attachment 318738 [details]
Patch

[Mathias Bynens]

Comment on attachment 318738 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318738&action=review

> PerformanceTests/Speedometer/resources/main.js:154
> +        var parts = location.search.substring(1).split('&');

Shame Edge doesn’t support `URLSearchParams` yet — that would simplify this section greatly!

> PerformanceTests/Speedometer/resources/main.js:171
> +                    console.error('Invalid iteratin count: ' + value);

typo: iteration

[Saam Barati]

Comment on attachment 318738 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318738&action=review

> PerformanceTests/Speedometer/resources/main.js:160
> +            case 'unit':

Why have this parameter if only “ms” is allowed?

> PerformanceTests/Speedometer/resources/main.js:168
> +                if (!isNaN(value))

Should be isNaN(parsedValue)

[Ryosuke Niwa]

(In reply to Saam Barati from comment #3)
> Comment on attachment 318738 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=318738&action=review
> 
> > PerformanceTests/Speedometer/resources/main.js:160
> > +            case 'unit':
> 
> Why have this parameter if only “ms” is allowed?

Just for clarity. ?unit=ms reads better than ?ms.

> > PerformanceTests/Speedometer/resources/main.js:168
> > +                if (!isNaN(value))
> 
> Should be isNaN(parsedValue)

Oops, fixed.

[Ryosuke Niwa]

(In reply to Mathias Bynens from comment #2)
> Comment on attachment 318738 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=318738&action=review
> 
> > PerformanceTests/Speedometer/resources/main.js:154
> > +        var parts = location.search.substring(1).split('&');
> 
> Shame Edge doesn’t support `URLSearchParams` yet — that would simplify this
> section greatly!
> 
> > PerformanceTests/Speedometer/resources/main.js:171
> > +                    console.error('Invalid iteratin count: ' + value);
> 
> typo: iteration

Fixed.

[Ryosuke Niwa]

Committed r221044: <http://trac.webkit.org/changeset/221044>

[Radar WebKit Bug Importer]

<rdar://problem/34020863>