Bug 175799

Summary: [WPE][GTK] Unused variables in UserMediaProcessManager.cpp
Product: WebKit Reporter: Adrian Perez <aperez>
Component: WebKit Misc.Assignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, darin, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adrian Perez
Reported 2017-08-21 17:19:59 PDT
Building the GTK+ port (or the WPE one) with Clang results in: ../../Source/WebKit/UIProcess/UserMediaProcessManager.cpp:33:26: warning: unused variable 'audioExtensionPath' [-Wunused-const-variable] static const char* const audioExtensionPath = "com.apple.webkit.microphone"; ^ ../../Source/WebKit/UIProcess/UserMediaProcessManager.cpp:34:26: warning: unused variable 'videoExtensionPath' [-Wunused-const-variable] static const char* const videoExtensionPath = "com.apple.webkit.camera"; ^ 2 warnings generated. These variables should be guarded by “#if ENABLE(SANDBOX_EXTENSIONS)”.
Attachments
Patch (1.43 KB, patch)
2017-08-21 17:23 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2017-08-21 17:23:56 PDT
Created attachment 318704 [details] Patch
WebKit Commit Bot
Comment 2 2017-08-21 18:14:18 PDT
Comment on attachment 318704 [details] Patch Clearing flags on attachment: 318704 Committed r220995: <http://trac.webkit.org/changeset/220995>
WebKit Commit Bot
Comment 3 2017-08-21 18:14:19 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2017-08-21 18:15:28 PDT
<rdar://problem/34004298>
Note You need to log in before you can comment on or make changes to this bug.