Bug 175799

Summary: [WPE][GTK] Unused variables in UserMediaProcessManager.cpp
Product: WebKit Reporter: Adrian Perez <aperez>
Component: WebKit Misc.Assignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, darin, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Adrian Perez 2017-08-21 17:19:59 PDT
Building the GTK+ port (or the WPE one) with Clang results in:

  ../../Source/WebKit/UIProcess/UserMediaProcessManager.cpp:33:26: warning: unused variable 'audioExtensionPath' [-Wunused-const-variable]
  static const char* const audioExtensionPath = "com.apple.webkit.microphone";
                           ^
  ../../Source/WebKit/UIProcess/UserMediaProcessManager.cpp:34:26: warning: unused variable 'videoExtensionPath' [-Wunused-const-variable]
  static const char* const videoExtensionPath = "com.apple.webkit.camera";
                           ^
  2 warnings generated.

These variables should be guarded by “#if ENABLE(SANDBOX_EXTENSIONS)”.
Comment 1 Adrian Perez 2017-08-21 17:23:56 PDT
Created attachment 318704 [details]
Patch
Comment 2 WebKit Commit Bot 2017-08-21 18:14:18 PDT
Comment on attachment 318704 [details]
Patch

Clearing flags on attachment: 318704

Committed r220995: <http://trac.webkit.org/changeset/220995>
Comment 3 WebKit Commit Bot 2017-08-21 18:14:19 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2017-08-21 18:15:28 PDT
<rdar://problem/34004298>