Bug 175797

Summary: Add UIDelegatePrivate SPI corresponding to WKPageUIClient.showPage
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, ggaren, jlewis3, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2017-08-21 17:10:25 PDT
Add UIDelegatePrivate SPI corresponding to WKPageUIClient.showPage
Attachments
Patch (15.95 KB, patch)
2017-08-21 17:19 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (18.07 KB, patch)
2017-08-22 14:45 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (17.41 KB, patch)
2017-08-22 15:05 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-08-21 17:19:16 PDT
Created attachment 318703 [details] Patch
Geoffrey Garen
Comment 2 2017-08-22 10:16:20 PDT
Comment on attachment 318703 [details] Patch r=me
WebKit Commit Bot
Comment 3 2017-08-22 11:12:13 PDT
Comment on attachment 318703 [details] Patch Clearing flags on attachment: 318703 Committed r221026: <http://trac.webkit.org/changeset/221026>
WebKit Commit Bot
Comment 4 2017-08-22 11:12:15 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-08-22 11:13:25 PDT
<rdar://problem/34016741>
Matt Lewis
Comment 6 2017-08-22 14:09:46 PDT
This caused an api timeout with the test WebKit2.ShowPage on iOS Simulators https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Release%20WK2%20%28Tests%29/builds/3781/steps/run-api-tests/logs/stdio
Matt Lewis
Comment 7 2017-08-22 14:10:17 PDT
Reverted r221026 for reason: This caused a consistent API failure on iOS Simulator. Committed r221047: <http://trac.webkit.org/changeset/221047>
Alex Christensen
Comment 8 2017-08-22 14:45:13 PDT
Created attachment 318802 [details] Patch
Alex Christensen
Comment 9 2017-08-22 15:05:33 PDT
Created attachment 318804 [details] Patch
Alex Christensen
Comment 10 2017-08-22 16:15:19 PDT
http://trac.webkit.org/r221055
Tim Horton
Comment 11 2017-08-22 16:20:50 PDT
What's up with the icky name?
Alex Christensen
Comment 12 2017-08-23 10:10:15 PDT
_webViewClose corresponds with WKPageUIClient.close. I figured _webViewShow was a good name for a function that corresponds with WKPageUIClient.showPage. All the other methods in UIDelegatePrivate start with _webView...
Tim Horton
Comment 13 2017-08-23 10:28:08 PDT
(In reply to Alex Christensen from comment #12) > _webViewClose corresponds with WKPageUIClient.close. I figured _webViewShow > was a good name for a function that corresponds with > WKPageUIClient.showPage. You figured incorrectly :) It should at a /minimum/ be -(void)_showWebView:(WKWebView *)webView. Please fix! > All the other methods in UIDelegatePrivate start > with _webView... Not true.
Note You need to log in before you can comment on or make changes to this bug.